Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270901: Typo PHASE_CPP in CompilerPhaseType #228

Closed

Conversation

kelthuzadx
Copy link
Member

@kelthuzadx kelthuzadx commented Nov 5, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/228/head:pull/228
$ git checkout pull/228

Update a local copy of the PR:
$ git checkout pull/228
$ git pull https://git.openjdk.java.net/jdk17u pull/228/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 228

View PR using the GUI difftool:
$ git pr show -t 228

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/228.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 5, 2021

👋 Welcome back yyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 072fe486c952184811f5bff3504ca72deb66e445 8270901: Typo PHASE_CPP in CompilerPhaseType Nov 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

@kelthuzadx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270901: Typo PHASE_CPP in CompilerPhaseType

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • e160532: 8272345: macos doesn't check os::set_boot_path() result
  • 6d63a86: 8272114: Unused _last_state in osThread_windows
  • a384377: 8268626: Remove native pre-jdk9 support for jtreg failure handler
  • 9a2c123: 4819544: SwingSet2 JTable Demo throws NullPointerException
  • 0ab99ed: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML
  • a834b58: 8269269: [macos11] SystemIconTest fails with ClassCastException
  • 23326d5: 8266510: Nimbus JTree default tree cell renderer does not use selected text color
  • 00fed20: 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows
  • 9f3c840: 8268361: Fix the infinite loop in next_line
  • 4003db8: 8268464: Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests
  • ... and 2 more: https://git.openjdk.java.net/jdk17u/compare/802844ae738fd8b1a2fb7708b95e2b1759375f9b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Nov 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 5, 2021

Webrevs

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Nov 5, 2021

/integrate

@openjdk openjdk bot added the sponsor label Nov 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

@kelthuzadx
Your change (at version 96aeb0f) is now ready to be sponsored by a Committer.

@vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Nov 5, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

Going to push as commit dc93934.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 6c86a41: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
  • e160532: 8272345: macos doesn't check os::set_boot_path() result
  • 6d63a86: 8272114: Unused _last_state in osThread_windows
  • a384377: 8268626: Remove native pre-jdk9 support for jtreg failure handler
  • 9a2c123: 4819544: SwingSet2 JTable Demo throws NullPointerException
  • 0ab99ed: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML
  • a834b58: 8269269: [macos11] SystemIconTest fails with ClassCastException
  • 23326d5: 8266510: Nimbus JTree default tree cell renderer does not use selected text color
  • 00fed20: 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows
  • 9f3c840: 8268361: Fix the infinite loop in next_line
  • ... and 3 more: https://git.openjdk.java.net/jdk17u/compare/802844ae738fd8b1a2fb7708b95e2b1759375f9b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

@vnkozlov @kelthuzadx Pushed as commit dc93934.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants