Skip to content

Conversation

@akashche
Copy link
Contributor

@akashche akashche commented Nov 5, 2021

Clean backport of a Mac-specfic test fix. The change is test only.

Note, this test was added to problem list with JDK-8271894 (in 17) and removed from problem list with JDK-8271895 that is intended to be added as a follow up.

Note 2, this is a re-creaton of a PR #164 that failed jcheck for some reason.

Additional testing:

  • checked that test passes on Mac

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8268284: javax/swing/JComponent/7154030/bug7154030.java fails with "Exception: Failed to hide opaque button"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/229/head:pull/229
$ git checkout pull/229

Update a local copy of the PR:
$ git checkout pull/229
$ git pull https://git.openjdk.java.net/jdk17u pull/229/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 229

View PR using the GUI difftool:
$ git pr show -t 229

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/229.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2021

👋 Welcome back akasko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 534f00510e26da8deb891b4184c860ec64991b8f 8268284: javax/swing/JComponent/7154030/bug7154030.java fails with "Exception: Failed to hide opaque button" Nov 5, 2021
@openjdk
Copy link

openjdk bot commented Nov 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 5, 2021
@akashche
Copy link
Contributor Author

akashche commented Nov 5, 2021

It seems that JDK-8271895 backport should be pushed first to satisfy jcheck, will open a PR for it.

@akashche
Copy link
Contributor Author

akashche commented Nov 5, 2021

Opened #230 for JDK-8271895.

@openjdk
Copy link

openjdk bot commented Nov 9, 2021

@akashche This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268284: javax/swing/JComponent/7154030/bug7154030.java fails with "Exception: Failed to hide opaque button"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 143cc64: 8273026: Slow LoginContext.login() on multi threading application
  • aadd484: 8271895: UnProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK18
  • 43ae179: 8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS
  • 7176520: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point
  • e829c85: 8273021: C2: Improve Add and Xor ideal optimizations
  • dc93934: 8270901: Typo PHASE_CPP in CompilerPhaseType
  • 6c86a41: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
  • e160532: 8272345: macos doesn't check os::set_boot_path() result

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 9, 2021
@akashche
Copy link
Contributor Author

akashche commented Nov 9, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Nov 9, 2021

Going to push as commit 05ad02f.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 143cc64: 8273026: Slow LoginContext.login() on multi threading application
  • aadd484: 8271895: UnProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK18
  • 43ae179: 8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS
  • 7176520: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point
  • e829c85: 8273021: C2: Improve Add and Xor ideal optimizations
  • dc93934: 8270901: Typo PHASE_CPP in CompilerPhaseType
  • 6c86a41: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
  • e160532: 8272345: macos doesn't check os::set_boot_path() result

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 9, 2021
@openjdk
Copy link

openjdk bot commented Nov 9, 2021

@akashche Pushed as commit 05ad02f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@akashche akashche deleted the 8268284-backport branch November 9, 2021 14:18
@mlbridge
Copy link

mlbridge bot commented Nov 9, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant