Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails #23

Closed
wants to merge 1 commit into from

Conversation

thejasviv
Copy link
Member

@thejasviv thejasviv commented Aug 19, 2021

This is a straight, clean backport of the following bug:

8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails

The patch applies cleanly, and the test passes on all platforms post the fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/23/head:pull/23
$ git checkout pull/23

Update a local copy of the PR:
$ git checkout pull/23
$ git pull https://git.openjdk.java.net/jdk17u pull/23/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23

View PR using the GUI difftool:
$ git pr show -t 23

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/23.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 19, 2021

👋 Welcome back tvoniadka! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 45abbeed2f4f2899a3c1595b0cd8e573990a16fa 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails Aug 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

@thejasviv This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 551354e: 8225083: Remove Google certificate that is expiring in December 2021
  • f002833: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
  • 790d9a9: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj
  • 8a20dfe: 8271203: C2: assert(iff->Opcode() == Op_If || iff->Opcode() == Op_CountedLoopEnd || iff->Opcode() == Op_RangeCheck) failed: Check this code when new subtype is added
  • 66bd0d5: 8271276: C2: Wrong JVM state used for receiver null check
  • 32f026a: 8268963: [IR Framework] Some default regexes matching on PrintOptoAssembly in IRNode.java do not work on all platforms
  • 9489ab7: 8271925: ZGC: Arraycopy stub passes invalid oop to load barrier
  • 90341db: 8268019: C2: assert(no_dead_loop) failed: dead loop detected
  • 52c3e7d: 8270098: ZGC: ZBarrierSetC2::clone_at_expansion fails with "Guard against surprises" assert
  • cb7e311: 8261088: Repeatable annotations without @target cannot have containers that target module declarations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Aug 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 19, 2021

Webrevs

@thejasviv
Copy link
Member Author

@thejasviv thejasviv commented Aug 19, 2021

/integrate

@openjdk openjdk bot added the sponsor label Aug 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

@thejasviv
Your change (at version 069f9a4) is now ready to be sponsored by a Committer.

@akolarkunnu
Copy link
Contributor

@akolarkunnu akolarkunnu commented Aug 19, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

Going to push as commit efeb10b.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 551354e: 8225083: Remove Google certificate that is expiring in December 2021
  • f002833: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
  • 790d9a9: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj
  • 8a20dfe: 8271203: C2: assert(iff->Opcode() == Op_If || iff->Opcode() == Op_CountedLoopEnd || iff->Opcode() == Op_RangeCheck) failed: Check this code when new subtype is added
  • 66bd0d5: 8271276: C2: Wrong JVM state used for receiver null check
  • 32f026a: 8268963: [IR Framework] Some default regexes matching on PrintOptoAssembly in IRNode.java do not work on all platforms
  • 9489ab7: 8271925: ZGC: Arraycopy stub passes invalid oop to load barrier
  • 90341db: 8268019: C2: assert(no_dead_loop) failed: dead loop detected
  • 52c3e7d: 8270098: ZGC: ZBarrierSetC2::clone_at_expansion fails with "Guard against surprises" assert
  • cb7e311: 8261088: Repeatable annotations without @target cannot have containers that target module declarations

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Aug 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

@akolarkunnu @thejasviv Pushed as commit efeb10b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants