Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271895: UnProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK18 #230

Closed
wants to merge 1 commit into from

Conversation

akashche
Copy link
Contributor

@akashche akashche commented Nov 5, 2021

Clean backport of the ProblemList.txt entry removal.

It seems to be required to be pushed first to proceed with #229 .


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8271895: UnProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK18

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/230/head:pull/230
$ git checkout pull/230

Update a local copy of the PR:
$ git checkout pull/230
$ git pull https://git.openjdk.java.net/jdk17u pull/230/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 230

View PR using the GUI difftool:
$ git pr show -t 230

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/230.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 5, 2021

👋 Welcome back akasko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7728423f8a4cf2b60d9774405b18a28ee498f268 8271895: UnProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK18 Nov 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

@akashche This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271895: UnProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK18

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e160532: 8272345: macos doesn't check os::set_boot_path() result

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Nov 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 5, 2021

Webrevs

@akashche
Copy link
Contributor Author

@akashche akashche commented Nov 9, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 9, 2021

Going to push as commit aadd484.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 43ae179: 8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS
  • 7176520: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point
  • e829c85: 8273021: C2: Improve Add and Xor ideal optimizations
  • dc93934: 8270901: Typo PHASE_CPP in CompilerPhaseType
  • 6c86a41: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
  • e160532: 8272345: macos doesn't check os::set_boot_path() result

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 9, 2021

@akashche Pushed as commit aadd484.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@akashche akashche deleted the 8271895-backport branch Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant