Skip to content

8276572: Fake libsyslookup.so library causes tooling issues#233

Closed
gnu-andrew wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:gnu-andrew-backport-a4724332
Closed

8276572: Fake libsyslookup.so library causes tooling issues#233
gnu-andrew wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:gnu-andrew-backport-a4724332

Conversation

@gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Nov 5, 2021

Change needed in 17u as well to unblock our builds of this LTS release. jdk17u-fix-request made on the original bug.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8276572: Fake libsyslookup.so library causes tooling issues

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/233/head:pull/233
$ git checkout pull/233

Update a local copy of the PR:
$ git checkout pull/233
$ git pull https://git.openjdk.java.net/jdk17u pull/233/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 233

View PR using the GUI difftool:
$ git pr show -t 233

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/233.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2021

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a4724332098cd8bff44ee27e9190fd28fa5c1865 8276572: Fake libsyslookup.so library causes tooling issues Nov 5, 2021
@openjdk
Copy link

openjdk bot commented Nov 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 5, 2021
@openjdk
Copy link

openjdk bot commented Nov 5, 2021

@gnu-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276572: Fake libsyslookup.so library causes tooling issues

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 5, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 5, 2021

Webrevs

@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 10, 2021

Going to push as commit 6bb5494.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 4eeefb4: 8275666: serviceability/jvmti/GetObjectSizeClass.java shouldn't have vm.flagless
  • ed48774: 8274523: java/lang/management/MemoryMXBean/MemoryTest.java test should handle Shenandoah
  • acd939e: 8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah
  • 0b52b9d: 8276550: Use SHA256 hash in build.tools.depend.Depend
  • 05ad02f: 8268284: javax/swing/JComponent/7154030/bug7154030.java fails with "Exception: Failed to hide opaque button"
  • 143cc64: 8273026: Slow LoginContext.login() on multi threading application
  • aadd484: 8271895: UnProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK18
  • 43ae179: 8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS
  • 7176520: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 10, 2021
@openjdk
Copy link

openjdk bot commented Nov 10, 2021

@gnu-andrew Pushed as commit 6bb5494.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant