Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275666: serviceability/jvmti/GetObjectSizeClass.java shouldn't have vm.flagless #236

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 8, 2021

Clean backport to fix the test. Effectively reverts a hunk from commit that went in JDK 17.

Additional testing:

  • Affected test still passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8275666: serviceability/jvmti/GetObjectSizeClass.java shouldn't have vm.flagless

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/236/head:pull/236
$ git checkout pull/236

Update a local copy of the PR:
$ git checkout pull/236
$ git pull https://git.openjdk.java.net/jdk17u pull/236/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 236

View PR using the GUI difftool:
$ git pr show -t 236

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/236.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cea3f010460c4b45e76bfac8a5b193c49fdd274a 8275666: serviceability/jvmti/GetObjectSizeClass.java shouldn't have vm.flagless Nov 8, 2021
@openjdk
Copy link

openjdk bot commented Nov 8, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 8, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275666: serviceability/jvmti/GetObjectSizeClass.java shouldn't have vm.flagless

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2021

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Nov 9, 2021

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 9, 2021

Going to push as commit 4eeefb4.
Since your change was applied there have been 8 commits pushed to the master branch:

  • ed48774: 8274523: java/lang/management/MemoryMXBean/MemoryTest.java test should handle Shenandoah
  • acd939e: 8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah
  • 0b52b9d: 8276550: Use SHA256 hash in build.tools.depend.Depend
  • 05ad02f: 8268284: javax/swing/JComponent/7154030/bug7154030.java fails with "Exception: Failed to hide opaque button"
  • 143cc64: 8273026: Slow LoginContext.login() on multi threading application
  • aadd484: 8271895: UnProblemList javax/swing/JComponent/7154030/bug7154030.java in JDK18
  • 43ae179: 8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS
  • 7176520: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 9, 2021
@openjdk
Copy link

openjdk bot commented Nov 9, 2021

@shipilev Pushed as commit 4eeefb4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8275666-jvmti-getobjectsize branch Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant