Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271315: Redo: Nimbus JTree renderer properties persist across L&F changes #240

Closed
wants to merge 1 commit into from

Conversation

@akashche
Copy link
Contributor

@akashche akashche commented Nov 9, 2021

Clean backport of a Swing fix. This is a follow-up to #140 .

Additional testing:

  • checked that manual NimbusJTreeSelTextColor test passes (with and without the patch)
  • checked that NimbusPropertiesDoNotImplUIResource test fails without the patch and passes with the patch

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8271315: Redo: Nimbus JTree renderer properties persist across L&F changes

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/240/head:pull/240
$ git checkout pull/240

Update a local copy of the PR:
$ git checkout pull/240
$ git pull https://git.openjdk.java.net/jdk17u pull/240/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 240

View PR using the GUI difftool:
$ git pr show -t 240

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/240.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 9, 2021

👋 Welcome back akasko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e43a907f20f99fa1f788fcbe2e99631dd01578d4 8271315: Redo: Nimbus JTree renderer properties persist across L&F changes Nov 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 9, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 9, 2021

@akashche This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271315: Redo: Nimbus JTree renderer properties persist across L&F changes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 9, 2021

Webrevs

@akashche
Copy link
Contributor Author

@akashche akashche commented Nov 16, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 16, 2021

Going to push as commit 9ff9e62.
Since your change was applied there have been 22 commits pushed to the master branch:

  • e7e83d5: 8272369: java/io/File/GetXSpace.java failed with "RuntimeException: java.nio.file.NoSuchFileException: /run/user/0"
  • 1d11bcd: 8273486: Zero: Handle DiagnoseSyncOnValueBasedClasses VM option
  • 95726bf: 8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly
  • 93d8337: 8276846: JDK-8273416 is incomplete for UseSSE=1
  • 6f3cd6b: 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility
  • 7758191: 8274521: jdk/jfr/event/gc/detailed/TestGCLockerEvent.java fails when other GC is selected
  • cc09778: 8268860: Windows-Aarch64 build is failing in GitHub actions
  • e4425d8: 8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32
  • 6221d61: 8276112: Inconsistent scalar replacement debug info at safepoints
  • 24c7fe3: 8268294: Reusing HttpClient in a WebSocket.Listener hangs.
  • ... and 12 more: https://git.openjdk.java.net/jdk17u/compare/4eeefb49b147689b3974e8257609d652083b8d25...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 16, 2021

@akashche Pushed as commit 9ff9e62.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@akashche akashche deleted the 8271315-backport branch Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant