-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268860: Windows-Aarch64 build is failing in GitHub actions #243
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Got the push approval. /integrate |
Going to push as commit cc09778.
Your commit was automatically rebased without conflicts. |
The GHA support for Windows AArch64 was added in 16 by JDK-8256657, then disabled in 17 by JDK-8268861, then enabled back in 18 by this patch. 17u therefore needs to enable Windows AArch64 back for more testing coverage.
Additional testing:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/243/head:pull/243
$ git checkout pull/243
Update a local copy of the PR:
$ git checkout pull/243
$ git pull https://git.openjdk.java.net/jdk17u pull/243/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 243
View PR using the GUI difftool:
$ git pr show -t 243
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/243.diff