Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1} #245

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Nov 10, 2021

Clean backport, fixes x86_32 failures. Would be followed with a few related fixes.

Additional testing:

  • Linux x86_64 fastdebug tier1 (clean)
  • Linux x86_32 fastdebug tier1 (some known failures)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1}

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/245/head:pull/245
$ git checkout pull/245

Update a local copy of the PR:
$ git checkout pull/245
$ git pull https://git.openjdk.java.net/jdk17u pull/245/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 245

View PR using the GUI difftool:
$ git pr show -t 245

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/245.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 10, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 89ade1d7e88ee005c3fd2136d84e298d94f9a67c 8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1} Nov 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 10, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 10, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1}

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 7aaad16: 8238649: Call new Win32 API SetThreadDescription in os::set_native_thread_name
  • 16a191c: 8261579: AArch64: Support for weaker memory ordering in Atomic
  • 89a03fe: 8273450: Fix the copyright header of SVML files
  • 6bb5494: 8276572: Fake libsyslookup.so library causes tooling issues
  • 4eeefb4: 8275666: serviceability/jvmti/GetObjectSizeClass.java shouldn't have vm.flagless
  • ed48774: 8274523: java/lang/management/MemoryMXBean/MemoryTest.java test should handle Shenandoah
  • acd939e: 8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah
  • 0b52b9d: 8276550: Use SHA256 hash in build.tools.depend.Depend
  • 05ad02f: 8268284: javax/swing/JComponent/7154030/bug7154030.java fails with "Exception: Failed to hide opaque button"
  • 143cc64: 8273026: Slow LoginContext.login() on multi threading application
  • ... and 3 more: https://git.openjdk.java.net/jdk17u/compare/e829c856b738d03db3ab210d3bde24b83af633cb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Nov 10, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 10, 2021

Webrevs

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Nov 15, 2021

Got the push approval.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 15, 2021

Going to push as commit c3de885.
Since your change was applied there have been 19 commits pushed to the master branch:

  • ff4f533: 8274560: JFR: Add test for OldObjectSample event when using Shenandoah
  • 23b4496: 8268927: Windows: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)"
  • a1036ef: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test
  • 193c7f1: 8274501: c2i entry barriers read int as long on AArch64
  • 3e349b4: 8276025: Hotspot's libsvml.so may conflict with user dependency
  • 58a6dae: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml
  • 7aaad16: 8238649: Call new Win32 API SetThreadDescription in os::set_native_thread_name
  • 16a191c: 8261579: AArch64: Support for weaker memory ordering in Atomic
  • 89a03fe: 8273450: Fix the copyright header of SVML files
  • 6bb5494: 8276572: Fake libsyslookup.so library causes tooling issues
  • ... and 9 more: https://git.openjdk.java.net/jdk17u/compare/e829c856b738d03db3ab210d3bde24b83af633cb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 15, 2021

@shipilev Pushed as commit c3de885.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8273416-bad-x86_32 branch Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant