Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269481: SctpMultiChannel never releases own file descriptor #247

Closed
wants to merge 1 commit into from

Conversation

@akashche
Copy link
Contributor

@akashche akashche commented Nov 10, 2021

Clean backport of the SCTP fix.

Additional testing:

  • with SCTP enabled in OS checked that added test fails without the patch and passes with the patch
  • ran jtreg:jdk/com/sun/nio/sctp/

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8269481: SctpMultiChannel never releases own file descriptor

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/247/head:pull/247
$ git checkout pull/247

Update a local copy of the PR:
$ git checkout pull/247
$ git pull https://git.openjdk.java.net/jdk17u pull/247/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 247

View PR using the GUI difftool:
$ git pr show -t 247

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/247.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 10, 2021

👋 Welcome back akasko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d1cecaaa22d551b93074c33209dac7354f4b6932 8269481: SctpMultiChannel never releases own file descriptor Nov 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 10, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 10, 2021

@akashche This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269481: SctpMultiChannel never releases own file descriptor

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 10, 2021

Webrevs

@akashche
Copy link
Contributor Author

@akashche akashche commented Nov 15, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 15, 2021

Going to push as commit b2f4dff.
Since your change was applied there have been 7 commits pushed to the master branch:

  • c3de885: 8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1}
  • ff4f533: 8274560: JFR: Add test for OldObjectSample event when using Shenandoah
  • 23b4496: 8268927: Windows: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)"
  • a1036ef: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test
  • 193c7f1: 8274501: c2i entry barriers read int as long on AArch64
  • 3e349b4: 8276025: Hotspot's libsvml.so may conflict with user dependency
  • 58a6dae: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 15, 2021

@akashche Pushed as commit b2f4dff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@akashche akashche deleted the 8269481-backport branch Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant