Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274471: Add support for RSASSA-PSS in OCSP Response #248

Closed
wants to merge 1 commit into from
Closed

8274471: Add support for RSASSA-PSS in OCSP Response #248

wants to merge 1 commit into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Nov 10, 2021

I'd like to backport JDK-8274471 to jdk17u

The patch fixes internal error upon verification of OCSP Response signed with RSASSA-PSS

The original patch applied with minor changes to src/java.base/share/classes/sun/security/provider/certpath/OCSP.java

Verified (20.04 LTS/amd64) with attached Test8274471.java.zip. Regression: jdk:tier2


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274471: Add support for RSASSA-PSS in OCSP Response

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/248/head:pull/248
$ git checkout pull/248

Update a local copy of the PR:
$ git checkout pull/248
$ git pull https://git.openjdk.java.net/jdk17u pull/248/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 248

View PR using the GUI difftool:
$ git pr show -t 248

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/248.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2021

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f63c4a832a1aea451f47aaf86d5361e970c6a28f 8274471: Add support for RSASSA-PSS in OCSP Response Nov 10, 2021
@openjdk
Copy link

openjdk bot commented Nov 10, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 10, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 10, 2021

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Backport looks good.

@openjdk
Copy link

openjdk bot commented Nov 29, 2021

@apavlyutkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274471: Add support for RSASSA-PSS in OCSP Response

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 75 new commits pushed to the master branch:

  • fbb7f2d: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream
  • a6c3b5d: 8277981: String Deduplication table is never cleaned up due to bad dead_factor_for_cleanup
  • 5406f14: 8277159: Fix java/nio/file/FileStore/Basic.java test by ignoring /run/user/* mount points
  • 1e4ec1d: 8274265: Suspicious string concatenation in logTestUtils.inline.hpp
  • cd6234d: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.
  • a1049e8: 8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak
  • 565ec1a: 8275863: Use encodeASCII for ASCII-compatible DoubleByte encodings
  • 14a1f2a: 8274242: Implement fast-path for ASCII-compatible CharsetEncoders on x86
  • 670d73e: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie
  • 2f51d80: 8275071: [macos] A11y cursor gets stuck when combobox is closed
  • ... and 65 more: https://git.openjdk.java.net/jdk17u/compare/89a03fef74bb5ac54adef7d48c672c3f59d55cba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 29, 2021
@apavlyutkin
Copy link
Contributor Author

apavlyutkin commented Dec 7, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 7, 2021
@openjdk
Copy link

openjdk bot commented Dec 7, 2021

@apavlyutkin
Your change (at version ab3eb3f) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Dec 23, 2021

Hi
unfortunately this missed 17.0.2 in jdk17u.
Please redo the change against jdk17u-dev.
I remove the jdk11u-fix-request tag in the meantime.

@apavlyutkin
Copy link
Contributor Author

apavlyutkin commented Dec 24, 2021

The changes will be backported to jdk17u_dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored
3 participants