Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility #251

Closed

Conversation

savoptik
Copy link
Contributor

@savoptik savoptik commented Nov 11, 2021

Hi all,

this pull request contains a backport of commit 9c6457f2 from the openjdk/jdk repository.

The commit being backported was authored by Artem Semenov on 9 Aug 2021 and was reviewed by Alexander Zuev, Pankaj Bansal and Sergey Bylokhov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility
  • JDK-8262031: Create implementation for NSAccessibilityNavigableStaticText protocol
  • JDK-8264287: Create implementation for NSAccessibilityComboBox protocol peer
  • JDK-8264303: Create implementation for NSAccessibilityTabGroup protocol peer
  • JDK-8264292: Create implementation for NSAccessibilityList protocol peer
  • JDK-8267387: Create implementation for NSAccessibilityOutline protocol
  • JDK-8267388: Create implementation for NSAccessibilityTable protocol
  • JDK-8264286: Create implementation for NSAccessibilityColumn protocol peer
  • JDK-8264298: Create implementation for NSAccessibilityRow protocol peer
  • JDK-8264291: Create implementation for NSAccessibilityCell protocol peer

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/251/head:pull/251
$ git checkout pull/251

Update a local copy of the PR:
$ git checkout pull/251
$ git pull https://git.openjdk.java.net/jdk17u pull/251/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 251

View PR using the GUI difftool:
$ git pr show -t 251

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/251.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2021

👋 Welcome back asemenov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9c6457f222e702b60fef4247c3e241c669eb9491 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility Nov 11, 2021
@openjdk
Copy link

openjdk bot commented Nov 11, 2021

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 11, 2021

@savoptik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility
8262031: Create implementation for NSAccessibilityNavigableStaticText protocol
8264287: Create implementation for NSAccessibilityComboBox protocol peer
8264303: Create implementation for NSAccessibilityTabGroup protocol peer
8264292: Create implementation for NSAccessibilityList protocol peer
8267387: Create implementation for NSAccessibilityOutline protocol
8267388: Create implementation for NSAccessibilityTable protocol
8264286: Create implementation for NSAccessibilityColumn protocol peer
8264298: Create implementation for NSAccessibilityRow protocol peer
8264291: Create implementation for NSAccessibilityCell protocol peer

Reviewed-by: kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 7758191: 8274521: jdk/jfr/event/gc/detailed/TestGCLockerEvent.java fails when other GC is selected
  • cc09778: 8268860: Windows-Aarch64 build is failing in GitHub actions
  • e4425d8: 8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32
  • 6221d61: 8276112: Inconsistent scalar replacement debug info at safepoints
  • 24c7fe3: 8268294: Reusing HttpClient in a WebSocket.Listener hangs.
  • b2f4dff: 8269481: SctpMultiChannel never releases own file descriptor
  • c3de885: 8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1}
  • ff4f533: 8274560: JFR: Add test for OldObjectSample event when using Shenandoah
  • 23b4496: 8268927: Windows: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)"
  • a1036ef: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test
  • ... and 1 more: https://git.openjdk.java.net/jdk17u/compare/3e349b436628f430946b7c571aeab09e35392ed5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@azuev-java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Nov 11, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 11, 2021

Webrevs

@savoptik
Copy link
Contributor Author

savoptik commented Nov 16, 2021

/штеупкфеу

@savoptik
Copy link
Contributor Author

savoptik commented Nov 16, 2021

/integrate

@openjdk openjdk bot added the sponsor label Nov 16, 2021
@openjdk
Copy link

openjdk bot commented Nov 16, 2021

@savoptik
Your change (at version 9d1de83) is now ready to be sponsored by a Committer.

@forantar
Copy link
Contributor

forantar commented Nov 16, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 16, 2021

Going to push as commit 6f3cd6b.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 7758191: 8274521: jdk/jfr/event/gc/detailed/TestGCLockerEvent.java fails when other GC is selected
  • cc09778: 8268860: Windows-Aarch64 build is failing in GitHub actions
  • e4425d8: 8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32
  • 6221d61: 8276112: Inconsistent scalar replacement debug info at safepoints
  • 24c7fe3: 8268294: Reusing HttpClient in a WebSocket.Listener hangs.
  • b2f4dff: 8269481: SctpMultiChannel never releases own file descriptor
  • c3de885: 8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1}
  • ff4f533: 8274560: JFR: Add test for OldObjectSample event when using Shenandoah
  • 23b4496: 8268927: Windows: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)"
  • a1036ef: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test
  • ... and 1 more: https://git.openjdk.java.net/jdk17u/compare/3e349b436628f430946b7c571aeab09e35392ed5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 16, 2021
@openjdk
Copy link

openjdk bot commented Nov 16, 2021

@forantar @savoptik Pushed as commit 6f3cd6b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
3 participants