Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275766: (tz) Update Timezone Data to 2021e #252

Closed
wants to merge 2 commits into from

Conversation

satoyoshiki
Copy link

@satoyoshiki satoyoshiki commented Nov 12, 2021

8275849: TestZoneInfo310.java fails with tzdata2021e
8276536: Update TimeZoneNames files to follow the changes made by JDK-8275766


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8275766: (tz) Update Timezone Data to 2021e ⚠️ Issue is not open.
  • JDK-8275849: TestZoneInfo310.java fails with tzdata2021e ⚠️ Issue is not open.
  • JDK-8276536: Update TimeZoneNames files to follow the changes made by JDK-8275766 ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/252/head:pull/252
$ git checkout pull/252

Update a local copy of the PR:
$ git checkout pull/252
$ git pull https://git.openjdk.java.net/jdk17u pull/252/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 252

View PR using the GUI difftool:
$ git pr show -t 252

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/252.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2021

👋 Welcome back ysatowse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@satoyoshiki
Copy link
Author

satoyoshiki commented Nov 12, 2021

/issue 8275849 8276536

@openjdk
Copy link

openjdk bot commented Nov 12, 2021

@satoyoshiki
Adding additional issue to issue list: 8275849: TestZoneInfo310.java fails with tzdata2021e.

Adding additional issue to issue list: 8276536: Update TimeZoneNames files to follow the changes made by JDK-8275766.

@satoyoshiki
Copy link
Author

satoyoshiki commented Nov 12, 2021

@naotoj @coffeys Please review this PR.
Two clean backports (8275766 and 8276536) are included.

@satoyoshiki satoyoshiki marked this pull request as ready for review Nov 12, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 12, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2021

Webrevs

Copy link
Contributor

@coffeys coffeys left a comment

Looks fine. Please be sure to request jdk17u integration approval for all 3 issues before committing.

@openjdk
Copy link

openjdk bot commented Nov 12, 2021

@satoyoshiki This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275766: (tz) Update Timezone Data to 2021e
8275849: TestZoneInfo310.java fails with tzdata2021e
8276536: Update TimeZoneNames files to follow the changes made by JDK-8275766

Reviewed-by: coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 816b5cd: 8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert
  • e5c70af: 8276854: Windows GHA builds fail due to broken Cygwin
  • e8eec1f: 8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian
  • 9ff9e62: 8271315: Redo: Nimbus JTree renderer properties persist across L&F changes
  • e7e83d5: 8272369: java/io/File/GetXSpace.java failed with "RuntimeException: java.nio.file.NoSuchFileException: /run/user/0"
  • 1d11bcd: 8273486: Zero: Handle DiagnoseSyncOnValueBasedClasses VM option
  • 95726bf: 8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly
  • 93d8337: 8276846: JDK-8273416 is incomplete for UseSSE=1
  • 6f3cd6b: 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility
  • 7758191: 8274521: jdk/jfr/event/gc/detailed/TestGCLockerEvent.java fails when other GC is selected
  • ... and 10 more: https://git.openjdk.java.net/jdk17u/compare/3e349b436628f430946b7c571aeab09e35392ed5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 12, 2021
@satoyoshiki
Copy link
Author

satoyoshiki commented Nov 16, 2021

Got approvals for 3 JBS issues.

@satoyoshiki
Copy link
Author

satoyoshiki commented Nov 16, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 16, 2021
@openjdk
Copy link

openjdk bot commented Nov 16, 2021

@satoyoshiki
Your change (at version 29961c6) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Nov 16, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 16, 2021

Going to push as commit f9eed14.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 816b5cd: 8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert
  • e5c70af: 8276854: Windows GHA builds fail due to broken Cygwin
  • e8eec1f: 8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian
  • 9ff9e62: 8271315: Redo: Nimbus JTree renderer properties persist across L&F changes
  • e7e83d5: 8272369: java/io/File/GetXSpace.java failed with "RuntimeException: java.nio.file.NoSuchFileException: /run/user/0"
  • 1d11bcd: 8273486: Zero: Handle DiagnoseSyncOnValueBasedClasses VM option
  • 95726bf: 8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly
  • 93d8337: 8276846: JDK-8273416 is incomplete for UseSSE=1
  • 6f3cd6b: 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility
  • 7758191: 8274521: jdk/jfr/event/gc/detailed/TestGCLockerEvent.java fails when other GC is selected
  • ... and 10 more: https://git.openjdk.java.net/jdk17u/compare/3e349b436628f430946b7c571aeab09e35392ed5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 16, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 16, 2021
@openjdk
Copy link

openjdk bot commented Nov 16, 2021

@coffeys @satoyoshiki Pushed as commit f9eed14.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants