Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges #253

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 12, 2021

Clean backport to improve Shenandoah performance.

Additional testing:

  • Linux x86_64 fastdebug hotspot_gc_shenandoah

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/253/head:pull/253
$ git checkout pull/253

Update a local copy of the PR:
$ git checkout pull/253
$ git pull https://git.openjdk.java.net/jdk17u pull/253/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 253

View PR using the GUI difftool:
$ git pr show -t 253

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/253.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3b0b6adc3d547fcf4b971536d2404c342d18046f 8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges Nov 12, 2021
@openjdk
Copy link

openjdk bot commented Nov 12, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 12, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 193c7f1: 8274501: c2i entry barriers read int as long on AArch64

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 12, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2021

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Nov 22, 2021

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 22, 2021

Going to push as commit 716eeb0.
Since your change was applied there have been 41 commits pushed to the master branch:

  • 01a9e63: 8276864: Update boot JDKs to 17.0.1 in GHA
  • 66c051a: 8275426: PretouchTask num_chunks calculation can overflow
  • 2d69b2d: 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE
  • 6aa02d7: 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem
  • 38db452: 8272170: Missing memory barrier when checking active state for regions
  • acecce5: 8276801: gc/stress/CriticalNativeStress.java fails intermittently with Shenandoah
  • 19201da: 8276905: Use appropriate macosx_version_minimum value while compiling metal shaders
  • 55f8d8c: 8271308: (fc) FileChannel.transferTo() transfers no more than Integer.MAX_VALUE bytes in one call
  • fdcc3f1: 8233020: (fs) UnixFileSystemProvider should use StaticProperty.userDir().
  • 0e896e7: 8277029: JMM GetDiagnosticXXXInfo APIs should verify output array sizes
  • ... and 31 more: https://git.openjdk.java.net/jdk17u/compare/3e349b436628f430946b7c571aeab09e35392ed5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 22, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2021
@openjdk
Copy link

openjdk bot commented Nov 22, 2021

@shipilev Pushed as commit 716eeb0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8275226-shenandoah-relax-ranges branch Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant