Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233020: (fs) UnixFileSystemProvider should use StaticProperty.userDir(). #263

Closed
wants to merge 1 commit into from

Conversation

akashche
Copy link
Contributor

@akashche akashche commented Nov 15, 2021

Clean backport of a minor fix to UnixFileSystemProvider.

Additional testing:

  • ran jtreg:java/nio/file/

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8233020: (fs) UnixFileSystemProvider should use StaticProperty.userDir().

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/263/head:pull/263
$ git checkout pull/263

Update a local copy of the PR:
$ git checkout pull/263
$ git pull https://git.openjdk.java.net/jdk17u pull/263/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 263

View PR using the GUI difftool:
$ git pr show -t 263

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/263.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2021

👋 Welcome back akasko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fd4de1ed404640ee0e744f022bbfa89db200ef05 8233020: (fs) UnixFileSystemProvider should use StaticProperty.userDir(). Nov 15, 2021
@openjdk
Copy link

openjdk bot commented Nov 15, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 15, 2021

@akashche This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8233020: (fs) UnixFileSystemProvider should use StaticProperty.userDir().

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Nov 15, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 15, 2021

Webrevs

@akashche
Copy link
Contributor Author

akashche commented Nov 19, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Nov 19, 2021

Going to push as commit fdcc3f1.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 0e896e7: 8277029: JMM GetDiagnosticXXXInfo APIs should verify output array sizes
  • 85f315b: 8272854: split runtime/CommandLine/PrintTouchedMethods.java test
  • 397bf95: 8275604: Zero: Reformat opclabels_data
  • 687dd87: 8276845: (fs) java/nio/file/spi/SetDefaultProvider.java fails on x86_32
  • e4cc0c1: 8276805: java/awt/print/PrinterJob/CheckPrivilege.java fails due to disabled SecurityManager
  • 7326f39: 8276306: jdk/jshell/CustomInputToolBuilder.java fails intermittently on storage acquisition
  • ddc81f2: 8274383: JNI call of getAccessibleSelection on a wrong thread
  • b7c7b84: 8271071: accessibility of a table on macOS lacks cell navigation
  • 076941f: 8271567: AArch64: AES Galois CounterMode (GCM) interleaved implementation using vector instructions
  • f1a8a22: 8276205: Shenandoah: CodeCache_lock should always be held for initializing code cache iteration
  • ... and 17 more: https://git.openjdk.java.net/jdk17u/compare/c3de885179fb77d9b502d3e33c0f5f63b00c631d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 19, 2021
@openjdk
Copy link

openjdk bot commented Nov 19, 2021

@akashche Pushed as commit fdcc3f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@akashche akashche deleted the 8233020-backport branch Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant