Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276864: Update boot JDKs to 17.0.1 in GHA #267

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Nov 16, 2021

Updates boot JDK to 17.0.1. Patch does not apply cleanly, because current 17u is on 16. I think it would be easier (but not exactly cleaner history-wise) to bump it to 17.0.1 with this backport.

Additional testing:

  • GHA builds are fine
  • GHA tests are fine

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/267/head:pull/267
$ git checkout pull/267

Update a local copy of the PR:
$ git checkout pull/267
$ git pull https://git.openjdk.java.net/jdk17u pull/267/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 267

View PR using the GUI difftool:
$ git pr show -t 267

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/267.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 16, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f561d3c1942ce901fa77c907839032f76feb6998 8276864: Update boot JDKs to 17.0.1 in GHA Nov 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 16, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Nov 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 16, 2021

Webrevs

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Nov 19, 2021

I need a formal review for this unclean backport, please.

Copy link
Contributor

@RealCLanger RealCLanger left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276864: Update boot JDKs to 17.0.1 in GHA

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • acecce5: 8276801: gc/stress/CriticalNativeStress.java fails intermittently with Shenandoah
  • 19201da: 8276905: Use appropriate macosx_version_minimum value while compiling metal shaders
  • 55f8d8c: 8271308: (fc) FileChannel.transferTo() transfers no more than Integer.MAX_VALUE bytes in one call
  • fdcc3f1: 8233020: (fs) UnixFileSystemProvider should use StaticProperty.userDir().
  • 0e896e7: 8277029: JMM GetDiagnosticXXXInfo APIs should verify output array sizes
  • 85f315b: 8272854: split runtime/CommandLine/PrintTouchedMethods.java test
  • 397bf95: 8275604: Zero: Reformat opclabels_data
  • 687dd87: 8276845: (fs) java/nio/file/spi/SetDefaultProvider.java fails on x86_32
  • e4cc0c1: 8276805: java/awt/print/PrinterJob/CheckPrivilege.java fails due to disabled SecurityManager
  • 7326f39: 8276306: jdk/jshell/CustomInputToolBuilder.java fails intermittently on storage acquisition
  • ... and 15 more: https://git.openjdk.java.net/jdk17u/compare/7758191d5afe3072d17fc79d5313fde9cb39fe11...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 19, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Nov 22, 2021

Got the push approval.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

Going to push as commit 01a9e63.
Since your change was applied there have been 29 commits pushed to the master branch:

  • 66c051a: 8275426: PretouchTask num_chunks calculation can overflow
  • 2d69b2d: 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE
  • 6aa02d7: 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem
  • 38db452: 8272170: Missing memory barrier when checking active state for regions
  • acecce5: 8276801: gc/stress/CriticalNativeStress.java fails intermittently with Shenandoah
  • 19201da: 8276905: Use appropriate macosx_version_minimum value while compiling metal shaders
  • 55f8d8c: 8271308: (fc) FileChannel.transferTo() transfers no more than Integer.MAX_VALUE bytes in one call
  • fdcc3f1: 8233020: (fs) UnixFileSystemProvider should use StaticProperty.userDir().
  • 0e896e7: 8277029: JMM GetDiagnosticXXXInfo APIs should verify output array sizes
  • 85f315b: 8272854: split runtime/CommandLine/PrintTouchedMethods.java test
  • ... and 19 more: https://git.openjdk.java.net/jdk17u/compare/7758191d5afe3072d17fc79d5313fde9cb39fe11...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@shipilev Pushed as commit 01a9e63.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8276864-17.0.1 branch Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants