Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276845: (fs) java/nio/file/spi/SetDefaultProvider.java fails on x86_32 #269

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 16, 2021

Clean backport to improve x86_32 test.

Additional testing:

  • Affected test now passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8276845: (fs) java/nio/file/spi/SetDefaultProvider.java fails on x86_32

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/269/head:pull/269
$ git checkout pull/269

Update a local copy of the PR:
$ git checkout pull/269
$ git pull https://git.openjdk.java.net/jdk17u pull/269/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 269

View PR using the GUI difftool:
$ git pr show -t 269

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/269.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0f463a7bf73791eda9404882ff63daf9040399bb 8276845: (fs) java/nio/file/spi/SetDefaultProvider.java fails on x86_32 Nov 16, 2021
@openjdk
Copy link

openjdk bot commented Nov 16, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 16, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276845: (fs) java/nio/file/spi/SetDefaultProvider.java fails on x86_32

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 16, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 16, 2021

Webrevs

@shipilev
Copy link
Member Author

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 19, 2021

Going to push as commit 687dd87.
Since your change was applied there have been 17 commits pushed to the master branch:

  • e4cc0c1: 8276805: java/awt/print/PrinterJob/CheckPrivilege.java fails due to disabled SecurityManager
  • 7326f39: 8276306: jdk/jshell/CustomInputToolBuilder.java fails intermittently on storage acquisition
  • ddc81f2: 8274383: JNI call of getAccessibleSelection on a wrong thread
  • b7c7b84: 8271071: accessibility of a table on macOS lacks cell navigation
  • 076941f: 8271567: AArch64: AES Galois CounterMode (GCM) interleaved implementation using vector instructions
  • f1a8a22: 8276205: Shenandoah: CodeCache_lock should always be held for initializing code cache iteration
  • 95573d4: 8268882: C2: assert(n->outcnt() != 0 || C->top() == n || n->is_Proj()) failed: No dead instructions after post-alloc
  • f9eed14: 8275766: (tz) Update Timezone Data to 2021e
  • 816b5cd: 8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert
  • e5c70af: 8276854: Windows GHA builds fail due to broken Cygwin
  • ... and 7 more: https://git.openjdk.java.net/jdk17u/compare/7758191d5afe3072d17fc79d5313fde9cb39fe11...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 19, 2021
@openjdk
Copy link

openjdk bot commented Nov 19, 2021

@shipilev Pushed as commit 687dd87.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8276845-set-default-provider branch December 20, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant