Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient #27

Closed
wants to merge 1 commit into from
Closed

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Aug 19, 2021

Clean backport to improve test stability.

Additional testing:

  • Affected tests still pass

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/27/head:pull/27
$ git checkout pull/27

Update a local copy of the PR:
$ git checkout pull/27
$ git pull https://git.openjdk.java.net/jdk17u pull/27/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27

View PR using the GUI difftool:
$ git pr show -t 27

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/27.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 19, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 23d2996fee54afcc386a505a65d3236aab874e9e 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient Aug 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 19, 2021

Webrevs

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Aug 23, 2021

Got the push approval.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

Going to push as commit 9554fba.
Since your change was applied there have been 2 commits pushed to the master branch:

  • bf920d9: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used
  • 24e5c1a: 8272326: java/util/Random/RandomTestMoments.java had two Gaussian fails

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

@shipilev Pushed as commit 9554fba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant