Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276801: gc/stress/CriticalNativeStress.java fails intermittently with Shenandoah #272

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Nov 16, 2021

A clean backport of Shenandoah specific patch.

This is a followup backport of JDK-8276205 to fix a bug that causes updates to nmethod while concurrent walk is in progress.

Test:

  • hotspot_gc_shenandoah

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8276801: gc/stress/CriticalNativeStress.java fails intermittently with Shenandoah

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/272/head:pull/272
$ git checkout pull/272

Update a local copy of the PR:
$ git checkout pull/272
$ git pull https://git.openjdk.java.net/jdk17u pull/272/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 272

View PR using the GUI difftool:
$ git pr show -t 272

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/272.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 73e6d7d74d2ddd27f11775944c6fc4fb5268106d 8276801: gc/stress/CriticalNativeStress.java fails intermittently with Shenandoah Nov 16, 2021
@openjdk
Copy link

openjdk bot commented Nov 16, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 16, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276801: gc/stress/CriticalNativeStress.java fails intermittently with Shenandoah

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 816b5cd: 8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert
  • e5c70af: 8276854: Windows GHA builds fail due to broken Cygwin
  • e8eec1f: 8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian
  • 9ff9e62: 8271315: Redo: Nimbus JTree renderer properties persist across L&F changes
  • e7e83d5: 8272369: java/io/File/GetXSpace.java failed with "RuntimeException: java.nio.file.NoSuchFileException: /run/user/0"
  • 1d11bcd: 8273486: Zero: Handle DiagnoseSyncOnValueBasedClasses VM option
  • 95726bf: 8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly
  • 93d8337: 8276846: JDK-8273416 is incomplete for UseSSE=1
  • 6f3cd6b: 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility
  • 7758191: 8274521: jdk/jfr/event/gc/detailed/TestGCLockerEvent.java fails when other GC is selected
  • ... and 5 more: https://git.openjdk.java.net/jdk17u/compare/c3de885179fb77d9b502d3e33c0f5f63b00c631d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 16, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 16, 2021

Webrevs

@zhengyu123
Copy link
Contributor Author

zhengyu123 commented Nov 19, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Nov 19, 2021

Going to push as commit acecce5.
Since your change was applied there have been 30 commits pushed to the master branch:

  • 19201da: 8276905: Use appropriate macosx_version_minimum value while compiling metal shaders
  • 55f8d8c: 8271308: (fc) FileChannel.transferTo() transfers no more than Integer.MAX_VALUE bytes in one call
  • fdcc3f1: 8233020: (fs) UnixFileSystemProvider should use StaticProperty.userDir().
  • 0e896e7: 8277029: JMM GetDiagnosticXXXInfo APIs should verify output array sizes
  • 85f315b: 8272854: split runtime/CommandLine/PrintTouchedMethods.java test
  • 397bf95: 8275604: Zero: Reformat opclabels_data
  • 687dd87: 8276845: (fs) java/nio/file/spi/SetDefaultProvider.java fails on x86_32
  • e4cc0c1: 8276805: java/awt/print/PrinterJob/CheckPrivilege.java fails due to disabled SecurityManager
  • 7326f39: 8276306: jdk/jshell/CustomInputToolBuilder.java fails intermittently on storage acquisition
  • ddc81f2: 8274383: JNI call of getAccessibleSelection on a wrong thread
  • ... and 20 more: https://git.openjdk.java.net/jdk17u/compare/c3de885179fb77d9b502d3e33c0f5f63b00c631d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 19, 2021
@openjdk
Copy link

openjdk bot commented Nov 19, 2021

@zhengyu123 Pushed as commit acecce5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant