Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276905: Use appropriate macosx_version_minimum value while compiling metal shaders #273

Closed

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Nov 16, 2021

Clean backport to 17u.
Metal pipeline was introduced in JDK17 and this fix resolves deployment target issue and needed in JDK17.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8276905: Use appropriate macosx_version_minimum value while compiling metal shaders

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/273/head:pull/273
$ git checkout pull/273

Update a local copy of the PR:
$ git checkout pull/273
$ git pull https://git.openjdk.java.net/jdk17u pull/273/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 273

View PR using the GUI difftool:
$ git pr show -t 273

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/273.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2021

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9a9a157a7d45cbfb016d4427931e1d5345210f7a 8276905: Use appropriate macosx_version_minimum value while compiling metal shaders Nov 16, 2021
@openjdk
Copy link

openjdk bot commented Nov 16, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 16, 2021

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276905: Use appropriate macosx_version_minimum value while compiling metal shaders

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • f9eed14: 8275766: (tz) Update Timezone Data to 2021e
  • 816b5cd: 8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert
  • e5c70af: 8276854: Windows GHA builds fail due to broken Cygwin
  • e8eec1f: 8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian
  • 9ff9e62: 8271315: Redo: Nimbus JTree renderer properties persist across L&F changes
  • e7e83d5: 8272369: java/io/File/GetXSpace.java failed with "RuntimeException: java.nio.file.NoSuchFileException: /run/user/0"
  • 1d11bcd: 8273486: Zero: Handle DiagnoseSyncOnValueBasedClasses VM option
  • 95726bf: 8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly
  • 93d8337: 8276846: JDK-8273416 is incomplete for UseSSE=1
  • 6f3cd6b: 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility
  • ... and 6 more: https://git.openjdk.java.net/jdk17u/compare/c3de885179fb77d9b502d3e33c0f5f63b00c631d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 16, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 16, 2021

Webrevs

@jayathirthrao
Copy link
Member Author

jayathirthrao commented Nov 19, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Nov 19, 2021

Going to push as commit 19201da.
Since your change was applied there have been 29 commits pushed to the master branch:

  • 55f8d8c: 8271308: (fc) FileChannel.transferTo() transfers no more than Integer.MAX_VALUE bytes in one call
  • fdcc3f1: 8233020: (fs) UnixFileSystemProvider should use StaticProperty.userDir().
  • 0e896e7: 8277029: JMM GetDiagnosticXXXInfo APIs should verify output array sizes
  • 85f315b: 8272854: split runtime/CommandLine/PrintTouchedMethods.java test
  • 397bf95: 8275604: Zero: Reformat opclabels_data
  • 687dd87: 8276845: (fs) java/nio/file/spi/SetDefaultProvider.java fails on x86_32
  • e4cc0c1: 8276805: java/awt/print/PrinterJob/CheckPrivilege.java fails due to disabled SecurityManager
  • 7326f39: 8276306: jdk/jshell/CustomInputToolBuilder.java fails intermittently on storage acquisition
  • ddc81f2: 8274383: JNI call of getAccessibleSelection on a wrong thread
  • b7c7b84: 8271071: accessibility of a table on macOS lacks cell navigation
  • ... and 19 more: https://git.openjdk.java.net/jdk17u/compare/c3de885179fb77d9b502d3e33c0f5f63b00c631d...master

Your commit was automatically rebased without conflicts.

@jayathirthrao
Copy link
Member Author

jayathirthrao commented Nov 19, 2021

Approved for 17u backport

@openjdk openjdk bot closed this Nov 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 19, 2021
@jayathirthrao jayathirthrao deleted the Backport_JDK-8276905 branch Nov 19, 2021
@openjdk
Copy link

openjdk bot commented Nov 19, 2021

@jayathirthrao Pushed as commit 19201da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant