Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit #274

Closed

Conversation

adamfarley
Copy link

@adamfarley adamfarley commented Nov 16, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/274/head:pull/274
$ git checkout pull/274

Update a local copy of the PR:
$ git checkout pull/274
$ git pull https://git.openjdk.java.net/jdk17u pull/274/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 274

View PR using the GUI difftool:
$ git pr show -t 274

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/274.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 16, 2021

👋 Welcome back afarley! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fc0fe256793b33430c1247e0c091150a091da3c4 8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit Nov 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 16, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 16, 2021

@adamfarley This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Nov 16, 2021
@adamfarley
Copy link
Author

@adamfarley adamfarley commented Nov 16, 2021

/integrate

@adamfarley
Copy link
Author

@adamfarley adamfarley commented Nov 16, 2021

Sponsor requested please.

@openjdk openjdk bot added the sponsor label Nov 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 16, 2021

@adamfarley
Your change (at version 792073c) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 16, 2021

Webrevs

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Nov 16, 2021

As stated in the jdk11u PR, please request JDK17 backport approval via jdk17u-fix-request label in the JBS bug.

@adamfarley
Copy link
Author

@adamfarley adamfarley commented Nov 16, 2021

Will do. :)

@adamfarley adamfarley closed this Nov 16, 2021
@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Nov 16, 2021

Will do. :)

This one doesn't need closing. For jdk17u, there is no dev repository, so you can reopen it... just wait for the JBS approval label.

@adamfarley adamfarley reopened this Nov 16, 2021
@shipilev
Copy link
Contributor

@shipilev shipilev commented Nov 23, 2021

Push approval (jdk17u-fix-yes) is there now, I am sponsoring.

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2021

Going to push as commit 03ef5a9.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 562cb4a: 8274942: AssertionError at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155)
  • 716eeb0: 8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges
  • 01a9e63: 8276864: Update boot JDKs to 17.0.1 in GHA
  • 66c051a: 8275426: PretouchTask num_chunks calculation can overflow
  • 2d69b2d: 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE
  • 6aa02d7: 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem
  • 38db452: 8272170: Missing memory barrier when checking active state for regions
  • acecce5: 8276801: gc/stress/CriticalNativeStress.java fails intermittently with Shenandoah
  • 19201da: 8276905: Use appropriate macosx_version_minimum value while compiling metal shaders
  • 55f8d8c: 8271308: (fc) FileChannel.transferTo() transfers no more than Integer.MAX_VALUE bytes in one call
  • ... and 12 more: https://git.openjdk.java.net/jdk17u/compare/f9eed140be80840531ddb40a5d28e2142eaab506...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2021

@shipilev @adamfarley Pushed as commit 03ef5a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@adamfarley
Copy link
Author

@adamfarley adamfarley commented Nov 23, 2021

Thanks @shipilev :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
3 participants