Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274383: JNI call of getAccessibleSelection on a wrong thread #280

Closed

Conversation

savoptik
Copy link
Contributor

@savoptik savoptik commented Nov 17, 2021

Hi all,

this pull request contains a backport of commit b36881fa from the openjdk/jdk repository.

The commit being backported was authored by Artem Semenov on 28 Sep 2021 and was reviewed by Alexander Zuev and Anton Tarasov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274383: JNI call of getAccessibleSelection on a wrong thread

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/280/head:pull/280
$ git checkout pull/280

Update a local copy of the PR:
$ git checkout pull/280
$ git pull https://git.openjdk.java.net/jdk17u pull/280/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 280

View PR using the GUI difftool:
$ git pr show -t 280

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/280.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 17, 2021

👋 Welcome back asemenov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b36881fa3b3f37400d4f2c0bca3192d88179f2ff 8274383: JNI call of getAccessibleSelection on a wrong thread Nov 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

@savoptik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274383: JNI call of getAccessibleSelection on a wrong thread

Reviewed-by: kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • b7c7b84: 8271071: accessibility of a table on macOS lacks cell navigation
  • 076941f: 8271567: AArch64: AES Galois CounterMode (GCM) interleaved implementation using vector instructions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@azuev-java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Nov 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 17, 2021

Webrevs

@savoptik
Copy link
Contributor Author

@savoptik savoptik commented Nov 17, 2021

/reviewer credit @azuev-java

@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

@savoptik
Reviewer kizune successfully credited.

Copy link
Member

@azuev-java azuev-java left a comment

Looks fine.

@savoptik
Copy link
Contributor Author

@savoptik savoptik commented Nov 19, 2021

/integrate

@openjdk openjdk bot added the sponsor label Nov 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2021

@savoptik
Your change (at version 43b5efc) is now ready to be sponsored by a Committer.

@forantar
Copy link
Contributor

@forantar forantar commented Nov 19, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2021

Going to push as commit ddc81f2.
Since your change was applied there have been 2 commits pushed to the master branch:

  • b7c7b84: 8271071: accessibility of a table on macOS lacks cell navigation
  • 076941f: 8271567: AArch64: AES Galois CounterMode (GCM) interleaved implementation using vector instructions

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2021

@forantar @savoptik Pushed as commit ddc81f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
3 participants