Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276927: [ppc64] Port shenandoahgc to linux on ppc64le #287

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Nov 18, 2021

Backport of 8276927: [PPC64] Port shenandoahgc to linux on ppc64le.
Applies cleanly, but a trivial resolution is required: add additional parameter , false /*unaligned*/ to mem2reg in ShenandoahBarrierSetAssembler::gen_pre_barrier_stub.
This is needed because "8269672: C1: Remove unaligned move on all architectures" is not in 17u.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276927: [ppc64] Port shenandoahgc to linux on ppc64le

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/287/head:pull/287
$ git checkout pull/287

Update a local copy of the PR:
$ git checkout pull/287
$ git pull https://git.openjdk.java.net/jdk17u pull/287/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 287

View PR using the GUI difftool:
$ git pr show -t 287

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/287.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 57eb864765f38185f8db8f1d37681d6cfe2a3c73 8276927: [ppc64] Port shenandoahgc to linux on ppc64le Nov 18, 2021
@openjdk
Copy link

openjdk bot commented Nov 18, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Nov 18, 2021
@TheRealMDoerr TheRealMDoerr marked this pull request as ready for review Nov 19, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 19, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 19, 2021

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Looks fine. Since this is a new thing that slides into PPC code cleanly, we have a rather low risk of regressions. But it would be nice to have mainline tested a bit with this change, at least to make sure it does not break the builds.

@openjdk
Copy link

openjdk bot commented Nov 19, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276927: [ppc64] Port shenandoahgc to linux on ppc64le

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • ddc81f2: 8274383: JNI call of getAccessibleSelection on a wrong thread
  • b7c7b84: 8271071: accessibility of a table on macOS lacks cell navigation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 19, 2021
@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Nov 19, 2021

Thanks for the review! I'm using this PR for testing. I'm planning to request 17u approval after some time (rather soon). Note that it was already tested for quite some time on our internal test infrastructure before we created the public PR.

@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Nov 23, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Nov 23, 2021

Going to push as commit d2d734c.
Since your change was applied there have been 24 commits pushed to the master branch:

  • dc7216a: 8275811: Incorrect instance to dispose
  • 6f2bdc0: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily
  • d998761: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test
  • 7ffac79: 8277195: missing CAccessibility definition in [CommonComponentAccessibility accessibilityHitTest]
  • 03ef5a9: 8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit
  • 562cb4a: 8274942: AssertionError at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155)
  • 716eeb0: 8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges
  • 01a9e63: 8276864: Update boot JDKs to 17.0.1 in GHA
  • 66c051a: 8275426: PretouchTask num_chunks calculation can overflow
  • 2d69b2d: 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE
  • ... and 14 more: https://git.openjdk.java.net/jdk17u/compare/076941f252e8e93ad4b6f846470798d798a952b3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2021
@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@TheRealMDoerr Pushed as commit d2d734c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8276927_shenandoah_ppc64 branch Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants