Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273678: TableAccessibility and TableRowAccessibility miss autorelease #289

Closed
wants to merge 1 commit into from

Conversation

savoptik
Copy link
Contributor

@savoptik savoptik commented Nov 19, 2021

This fix could not be backported automatically. WE have resolved the conflict.

  • On file: src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessible.java:135

Conflict lines:

- } else if (name.equals(ACCESSIBLE_ACTIVE_DESCENDANT_PROPERTY)) {
+ } else if (name.compareTo(ACCESSIBLE_ACTIVE_DESCENDANT_PROPERTY) == 0 ) {

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273678: TableAccessibility and TableRowAccessibility miss autorelease

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/289/head:pull/289
$ git checkout pull/289

Update a local copy of the PR:
$ git checkout pull/289
$ git pull https://git.openjdk.java.net/jdk17u pull/289/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 289

View PR using the GUI difftool:
$ git pr show -t 289

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/289.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2021

👋 Welcome back asemenov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3221a14f9eaf002d91597d84efdb125704710a4c 8273678: TableAccessibility and TableRowAccessibility miss autorelease Nov 19, 2021
@openjdk
Copy link

openjdk bot commented Nov 19, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 19, 2021

@savoptik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273678: TableAccessibility and TableRowAccessibility miss autorelease

Reviewed-by: kizune, pbansal, ant
Backport-of: 3221a14f9eaf002d91597d84efdb125704710a4c

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 846bf12: 8272047: java/nio/channels/FileChannel/Transfer2GPlus.java failed with Unexpected transfer size: 2147418112
  • f1d9e37: 8275809: crash in [CommonComponentAccessibility getCAccessible:withEnv:]
  • 63981ab: 8275819: [TableRowAccessibility accessibilityChildren] method is ineffective
  • 57e6e61: 8264293: Create implementation for NSAccessibilityMenu protocol peer
  • 8571633: 8277093: Vector should throw ClassNotFoundException for a missing class of an element
  • ed45df2: 8277212: GC accidentally cleans valid megamorphic vtable inline caches
  • c47e233: 8140241: (fc) Data transfer from FileChannel to itself causes hang in case of overlap
  • 9be7550: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64
  • d2d734c: 8276927: [ppc64] Port shenandoahgc to linux on ppc64le
  • dc7216a: 8275811: Incorrect instance to dispose
  • ... and 22 more: https://git.openjdk.java.net/jdk17u/compare/b7c7b84ef222d8ece30a23e714f03560a64cb7b4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@azuev-java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 19, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 19, 2021

Webrevs

@savoptik
Copy link
Contributor Author

/reviewer credit @forantar @azuev-java @pankaj-bansal

@openjdk
Copy link

openjdk bot commented Nov 19, 2021

@savoptik
Reviewer ant successfully credited.

Reviewer kizune successfully credited.

Reviewer pbansal successfully credited.

@forantar
Copy link
Contributor

/integrate

@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@forantar Only the author (@savoptik) is allowed to issue the integrate command.

@savoptik
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 24, 2021
@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@savoptik
Your change (at version ff0df22) is now ready to be sponsored by a Committer.

@forantar
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 24, 2021

Going to push as commit 865d24c.
Since your change was applied there have been 32 commits pushed to the master branch:

  • 846bf12: 8272047: java/nio/channels/FileChannel/Transfer2GPlus.java failed with Unexpected transfer size: 2147418112
  • f1d9e37: 8275809: crash in [CommonComponentAccessibility getCAccessible:withEnv:]
  • 63981ab: 8275819: [TableRowAccessibility accessibilityChildren] method is ineffective
  • 57e6e61: 8264293: Create implementation for NSAccessibilityMenu protocol peer
  • 8571633: 8277093: Vector should throw ClassNotFoundException for a missing class of an element
  • ed45df2: 8277212: GC accidentally cleans valid megamorphic vtable inline caches
  • c47e233: 8140241: (fc) Data transfer from FileChannel to itself causes hang in case of overlap
  • 9be7550: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64
  • d2d734c: 8276927: [ppc64] Port shenandoahgc to linux on ppc64le
  • dc7216a: 8275811: Incorrect instance to dispose
  • ... and 22 more: https://git.openjdk.java.net/jdk17u/compare/b7c7b84ef222d8ece30a23e714f03560a64cb7b4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 24, 2021
@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@forantar @savoptik Pushed as commit 865d24c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
4 participants