Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily #294

Closed
wants to merge 1 commit into from

Conversation

pkumaraswamy
Copy link
Contributor

@pkumaraswamy pkumaraswamy commented Nov 22, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/294/head:pull/294
$ git checkout pull/294

Update a local copy of the PR:
$ git checkout pull/294
$ git pull https://git.openjdk.java.net/jdk17u pull/294/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 294

View PR using the GUI difftool:
$ git pr show -t 294

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/294.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 22, 2021

👋 Welcome back pkumaraswamy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8822d41fdcc2c2d568badd72635dc587d21dbd63 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@pkumaraswamy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 716eeb0: 8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges
  • 01a9e63: 8276864: Update boot JDKs to 17.0.1 in GHA
  • 66c051a: 8275426: PretouchTask num_chunks calculation can overflow

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Nov 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 22, 2021

Webrevs

@pkumaraswamy
Copy link
Contributor Author

@pkumaraswamy pkumaraswamy commented Nov 22, 2021

/integrate

@openjdk openjdk bot added the sponsor label Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@pkumaraswamy
Your change (at version d7ec3b7) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

@coffeys coffeys commented Nov 23, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2021

Going to push as commit 6f2bdc0.
Since your change was applied there have been 7 commits pushed to the master branch:

  • d998761: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test
  • 7ffac79: 8277195: missing CAccessibility definition in [CommonComponentAccessibility accessibilityHitTest]
  • 03ef5a9: 8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit
  • 562cb4a: 8274942: AssertionError at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155)
  • 716eeb0: 8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges
  • 01a9e63: 8276864: Update boot JDKs to 17.0.1 in GHA
  • 66c051a: 8275426: PretouchTask num_chunks calculation can overflow

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2021

@coffeys @pkumaraswamy Pushed as commit 6f2bdc0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants