Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277385: Zero: Enable CompactStrings support #296

Closed

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Nov 22, 2021

Clean backport to improve Zero performance.

Additional testing:

  • Linux x86_64 fastdebug make bootcycle-images
  • Linux x86_32 fastdebug make bootcycle-images

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/296/head:pull/296
$ git checkout pull/296

Update a local copy of the PR:
$ git checkout pull/296
$ git pull https://git.openjdk.java.net/jdk17u pull/296/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 296

View PR using the GUI difftool:
$ git pr show -t 296

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/296.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 22, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3f847fe89a088d6921107ca887a7a1bace871bd6 8277385: Zero: Enable CompactStrings support Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277385: Zero: Enable CompactStrings support

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 716eeb0: 8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges
  • 01a9e63: 8276864: Update boot JDKs to 17.0.1 in GHA
  • 66c051a: 8275426: PretouchTask num_chunks calculation can overflow
  • 2d69b2d: 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE
  • 6aa02d7: 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem
  • 38db452: 8272170: Missing memory barrier when checking active state for regions
  • acecce5: 8276801: gc/stress/CriticalNativeStress.java fails intermittently with Shenandoah
  • 19201da: 8276905: Use appropriate macosx_version_minimum value while compiling metal shaders
  • 55f8d8c: 8271308: (fc) FileChannel.transferTo() transfers no more than Integer.MAX_VALUE bytes in one call
  • fdcc3f1: 8233020: (fs) UnixFileSystemProvider should use StaticProperty.userDir().
  • ... and 9 more: https://git.openjdk.java.net/jdk17u/compare/f1a8a22f54438ede20d73297b19b9f95cfc3ad21...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Nov 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 22, 2021

Webrevs

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 20, 2021

Please redo the PR on jdk17u-dev. Then you can push.

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Dec 20, 2021

Transplanted to openjdk/jdk17u-dev#5.

@shipilev shipilev closed this Dec 20, 2021
@shipilev shipilev deleted the JDK-8277385-zero-compactstrings branch Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready rfr
2 participants