Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264293: Create implementation for NSAccessibilityMenu protocol peer #298

Closed
wants to merge 1 commit into from

Conversation

@azuev-java
Copy link
Member

@azuev-java azuev-java commented Nov 22, 2021

Backport of JDK-8264293. Changes applied cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8264293: Create implementation for NSAccessibilityMenu protocol peer
  • JDK-8264296: Create implementation for NSAccessibilityPopUpButton protocol peer
  • JDK-8264295: Create implementation for NSAccessibilityMenuItem protocol peer
  • JDK-8264294: Create implementation for NSAccessibilityMenuBar protocol peer

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/298/head:pull/298
$ git checkout pull/298

Update a local copy of the PR:
$ git checkout pull/298
$ git pull https://git.openjdk.java.net/jdk17u pull/298/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 298

View PR using the GUI difftool:
$ git pr show -t 298

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/298.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 22, 2021

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8f5a8f740b62c27cc244debe57aaa2975f84a694 8264293: Create implementation for NSAccessibilityMenu protocol peer Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264293: Create implementation for NSAccessibilityMenu protocol peer
8264296: Create implementation for NSAccessibilityPopUpButton protocol peer
8264295: Create implementation for NSAccessibilityMenuItem protocol peer
8264294: Create implementation for NSAccessibilityMenuBar protocol peer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 22, 2021

Webrevs

@azuev-java
Copy link
Member Author

@azuev-java azuev-java commented Nov 23, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2021

Going to push as commit 57e6e61.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 8571633: 8277093: Vector should throw ClassNotFoundException for a missing class of an element
  • ed45df2: 8277212: GC accidentally cleans valid megamorphic vtable inline caches
  • c47e233: 8140241: (fc) Data transfer from FileChannel to itself causes hang in case of overlap
  • 9be7550: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64
  • d2d734c: 8276927: [ppc64] Port shenandoahgc to linux on ppc64le
  • dc7216a: 8275811: Incorrect instance to dispose
  • 6f2bdc0: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily
  • d998761: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test
  • 7ffac79: 8277195: missing CAccessibility definition in [CommonComponentAccessibility accessibilityHitTest]
  • 03ef5a9: 8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit
  • ... and 1 more: https://git.openjdk.java.net/jdk17u/compare/716eeb06a81a6533f4bca5ff5495f9178b60d487...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2021

@azuev-java Pushed as commit 57e6e61.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant