8276774: Cookie stored in CookieHandler not sent if user headers contain cookie

[evwhelan]

Hi,

Please review my clean backport of JDK-8276774

This fix passed all CI testing and fixes a regression introduced in JDK-8213189

Kind regards,
Evan

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8276774: Cookie stored in CookieHandler not sent if user headers contain cookie

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/300/head:pull/300
$ git checkout pull/300

Update a local copy of the PR:
$ git checkout pull/300
$ git pull https://git.openjdk.java.net/jdk17u pull/300/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 300

View PR using the GUI difftool:
$ git pr show -t 300

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/300.diff

[bridgekeeper]

👋 Welcome back ewhelan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@evwhelan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276774: Cookie stored in CookieHandler not sent if user headers contain cookie

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• d2d734c: 8276927: [ppc64] Port shenandoahgc to linux on ppc64le
• dc7216a: 8275811: Incorrect instance to dispose
• 6f2bdc0: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (ec645d4c)

[dfuch]

changes LGTM

[evwhelan]

/integrate

[openjdk]

@evwhelan
Your change (at version ec645d4) is now ready to be sponsored by a Committer.

[dfuch]

/sponsor

[openjdk]

Going to push as commit 670d73e.
Since your change was applied there have been 16 commits pushed to the master branch:

• 2f51d80: 8275071: [macos] A11y cursor gets stuck when combobox is closed
• e533d7b: 8264297: Create implementation for NSAccessibilityProgressIndicator protocol peer
• 6da0c63: 8272859: Javadoc external links should only have feature version number in URL
• 79ede93: 8271323: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -XX:TieredStopAtLevel=1
• 865d24c: 8273678: TableAccessibility and TableRowAccessibility miss autorelease
• 846bf12: 8272047: java/nio/channels/FileChannel/Transfer2GPlus.java failed with Unexpected transfer size: 2147418112
• f1d9e37: 8275809: crash in [CommonComponentAccessibility getCAccessible:withEnv:]
• 63981ab: 8275819: [TableRowAccessibility accessibilityChildren] method is ineffective
• 57e6e61: 8264293: Create implementation for NSAccessibilityMenu protocol peer
• 8571633: 8277093: Vector should throw ClassNotFoundException for a missing class of an element
• ... and 6 more: https://git.openjdk.java.net/jdk17u/compare/d998761ad3804aeff199774ca3db59b8f87e4f3b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch @evwhelan Pushed as commit 670d73e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.