Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275819: [TableRowAccessibility accessibilityChildren] method is ineffective #301

Closed

Conversation

forantar
Copy link
Contributor

@forantar forantar commented Nov 23, 2021

A fix for slow table accessing (a11y) that can be critical for long tables.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8275819: [TableRowAccessibility accessibilityChildren] method is ineffective

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/301/head:pull/301
$ git checkout pull/301

Update a local copy of the PR:
$ git checkout pull/301
$ git pull https://git.openjdk.java.net/jdk17u pull/301/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 301

View PR using the GUI difftool:
$ git pr show -t 301

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/301.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 23, 2021

👋 Welcome back ant! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b98ed55060b5f3b7832ec28064b04577e3725cc2 8275819: [TableRowAccessibility accessibilityChildren] method is ineffective Nov 23, 2021
@openjdk
Copy link

openjdk bot commented Nov 23, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Nov 23, 2021
@forantar
Copy link
Contributor Author

/reviewer credit @azuev-java @pankaj-bansal

@openjdk openjdk bot added the clean label Nov 23, 2021
@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@forantar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275819: [TableRowAccessibility accessibilityChildren] method is ineffective

Reviewed-by: kizune, pbansal
Backport-of: b98ed55060b5f3b7832ec28064b04577e3725cc2

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 8571633: 8277093: Vector should throw ClassNotFoundException for a missing class of an element
  • ed45df2: 8277212: GC accidentally cleans valid megamorphic vtable inline caches
  • c47e233: 8140241: (fc) Data transfer from FileChannel to itself causes hang in case of overlap
  • 9be7550: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2021
@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@forantar
Reviewer kizune successfully credited.

Reviewer pbansal successfully credited.

@mlbridge
Copy link

mlbridge bot commented Nov 23, 2021

Webrevs

@forantar
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 23, 2021

Going to push as commit 63981ab.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 57e6e61: 8264293: Create implementation for NSAccessibilityMenu protocol peer
  • 8571633: 8277093: Vector should throw ClassNotFoundException for a missing class of an element
  • ed45df2: 8277212: GC accidentally cleans valid megamorphic vtable inline caches
  • c47e233: 8140241: (fc) Data transfer from FileChannel to itself causes hang in case of overlap
  • 9be7550: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2021
@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@forantar Pushed as commit 63981ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants