Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264297: Create implementation for NSAccessibilityProgressIndicator protocol peer #305

Closed
wants to merge 1 commit into from

Conversation

@azuev-java
Copy link
Member

@azuev-java azuev-java commented Nov 23, 2021

Backport of JDK-8264297, fix applied without issues.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8264297: Create implementation for NSAccessibilityProgressIndicator protocol peer

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/305/head:pull/305
$ git checkout pull/305

Update a local copy of the PR:
$ git checkout pull/305
$ git pull https://git.openjdk.java.net/jdk17u pull/305/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 305

View PR using the GUI difftool:
$ git pr show -t 305

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/305.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 23, 2021

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 851a36247937d124e8217deaaa1a1831cba19b6e 8264297: Create implementation for NSAccessibilityProgressIndicator protocol peer Nov 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2021

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264297: Create implementation for NSAccessibilityProgressIndicator protocol peer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 23, 2021

Webrevs

@azuev-java
Copy link
Member Author

@azuev-java azuev-java commented Nov 24, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 24, 2021

Going to push as commit e533d7b.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 6da0c63: 8272859: Javadoc external links should only have feature version number in URL
  • 79ede93: 8271323: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -XX:TieredStopAtLevel=1
  • 865d24c: 8273678: TableAccessibility and TableRowAccessibility miss autorelease
  • 846bf12: 8272047: java/nio/channels/FileChannel/Transfer2GPlus.java failed with Unexpected transfer size: 2147418112
  • f1d9e37: 8275809: crash in [CommonComponentAccessibility getCAccessible:withEnv:]
  • 63981ab: 8275819: [TableRowAccessibility accessibilityChildren] method is ineffective

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 24, 2021

@azuev-java Pushed as commit e533d7b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant