Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak #307

Closed

Conversation

forantar
Copy link
Contributor

@forantar forantar commented Nov 24, 2021

A memory leak fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/307/head:pull/307
$ git checkout pull/307

Update a local copy of the PR:
$ git checkout pull/307
$ git pull https://git.openjdk.java.net/jdk17u pull/307/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 307

View PR using the GUI difftool:
$ git pr show -t 307

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/307.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2021

👋 Welcome back ant! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 574f8903ee1f74bdf7154d670d96c36d94b38b4d 8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak Nov 24, 2021
@openjdk
Copy link

openjdk bot commented Nov 24, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@forantar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak

Reviewed-by: kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 24, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2021

Webrevs

@forantar
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 26, 2021

Going to push as commit a1049e8.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 565ec1a: 8275863: Use encodeASCII for ASCII-compatible DoubleByte encodings
  • 14a1f2a: 8274242: Implement fast-path for ASCII-compatible CharsetEncoders on x86
  • 670d73e: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie
  • 2f51d80: 8275071: [macos] A11y cursor gets stuck when combobox is closed
  • e533d7b: 8264297: Create implementation for NSAccessibilityProgressIndicator protocol peer
  • 6da0c63: 8272859: Javadoc external links should only have feature version number in URL
  • 79ede93: 8271323: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -XX:TieredStopAtLevel=1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 26, 2021
@openjdk
Copy link

openjdk bot commented Nov 26, 2021

@forantar Pushed as commit a1049e8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants