Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274265: Suspicious string concatenation in logTestUtils.inline.hpp #312

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Nov 25, 2021

Hi all,

This pull request contains a backport of commit c57a6c62 from the openjdk/jdk repository.

The commit being backported was authored by Jesper Steen Møller on 28 Sep 2021 and was reviewed by Christoph Langer and Matthias Baesken.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274265: Suspicious string concatenation in logTestUtils.inline.hpp

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/312/head:pull/312
$ git checkout pull/312

Update a local copy of the PR:
$ git checkout pull/312
$ git pull https://git.openjdk.java.net/jdk17u pull/312/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 312

View PR using the GUI difftool:
$ git pr show -t 312

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/312.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 25, 2021

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c57a6c62baecde0bc10bfca89e0616b0c1fbb714 8274265: Suspicious string concatenation in logTestUtils.inline.hpp Nov 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 25, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 25, 2021

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274265: Suspicious string concatenation in logTestUtils.inline.hpp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Nov 25, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 25, 2021

Webrevs

@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Nov 29, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

Going to push as commit 1e4ec1d.
Since your change was applied there have been 2 commits pushed to the master branch:

  • cd6234d: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.
  • a1049e8: 8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@MBaesken Pushed as commit 1e4ec1d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant