Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories #314

Closed

Conversation

mlchung
Copy link
Member

@mlchung mlchung commented Nov 30, 2021

This pull request contains a backport of commit 7e54d065 from the openjdk/jdk repository.

The commit being backported was authored by Mandy Chung on 26 Nov 2021 and was reviewed by Jorn Vernee and Alan Bateman.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories
  • JDK-8277166: Data race in jdeps VersionHelper
  • JDK-8277123: jdeps does not report some exceptions correctly

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/314/head:pull/314
$ git checkout pull/314

Update a local copy of the PR:
$ git checkout pull/314
$ git pull https://git.openjdk.java.net/jdk17u pull/314/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 314

View PR using the GUI difftool:
$ git pr show -t 314

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/314.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2021

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7e54d065a17f1277adf1b8561fadb8a480bc6bed 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories Nov 30, 2021
@openjdk
Copy link

openjdk bot commented Nov 30, 2021

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 30, 2021

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories
8277166: Data race in jdeps VersionHelper
8277123: jdeps does not report some exceptions correctly

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 30, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 30, 2021

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Dec 23, 2021

Hi @mlchung please redo the PR against jdk17u-dev. I remove the jdk11u-fix-request tag in the meantime.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2022

@mlchung This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@simonis
Copy link
Member

simonis commented Feb 11, 2022

What's the state of this downport? We have a customer who is affected by this problem and would like to fix it in 17.

As far as I understand @GoeLin, this PR should be redone in jdk17u-dev, right?

@mlchung, do you want to do that or is it fine if I pick it up?

@mlchung
Copy link
Member Author

mlchung commented Feb 11, 2022

@simonis please go ahead and do the backport to jdk17-dev. I'll close this PR.

@mlchung mlchung closed this Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
3 participants