Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272472: StackGuardPages test doesn't build with glibc 2.34 #32

Closed
wants to merge 1 commit into from
Closed

8272472: StackGuardPages test doesn't build with glibc 2.34 #32

wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Aug 22, 2021

Backport of 8272472: StackGuardPages test doesn't build with glibc 2.34


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272472: StackGuardPages test doesn't build with glibc 2.34

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/32/head:pull/32
$ git checkout pull/32

Update a local copy of the PR:
$ git checkout pull/32
$ git pull https://git.openjdk.java.net/jdk17u pull/32/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32

View PR using the GUI difftool:
$ git pr show -t 32

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/32.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2021

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f77a1a156f3da9068d012d9227c7ee0fee58f571 8272472: StackGuardPages test doesn't build with glibc 2.34 Aug 22, 2021
@openjdk
Copy link

openjdk bot commented Aug 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 22, 2021

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272472: StackGuardPages test doesn't build with glibc 2.34

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 288 new commits pushed to the master branch:

  • bf920d9: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used
  • 24e5c1a: 8272326: java/util/Random/RandomTestMoments.java had two Gaussian fails
  • 704e6b9: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked
  • e9fd4b9: 8270280: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java OCSP response error
  • efeb10b: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails
  • 551354e: 8225083: Remove Google certificate that is expiring in December 2021
  • f002833: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
  • 790d9a9: 8272131: PhaseMacroExpand::generate_slow_arraycopy crash when clone null CallProjections.fallthrough_ioproj
  • 8a20dfe: 8271203: C2: assert(iff->Opcode() == Op_If || iff->Opcode() == Op_CountedLoopEnd || iff->Opcode() == Op_RangeCheck) failed: Check this code when new subtype is added
  • 66bd0d5: 8271276: C2: Wrong JVM state used for receiver null check
  • ... and 278 more: https://git.openjdk.java.net/jdk17u/compare/9ad19f7838e6f6e128583c191c5507c1e2bd5083...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 22, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2021

Webrevs

@dholmes-ora
Copy link
Member Author

Backport has been approved.

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 24, 2021

@dholmes-ora This change does not need sponsoring - the author is allowed to integrate it.

@dholmes-ora
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 24, 2021

Going to push as commit bb7c412.
Since your change was applied there have been 292 commits pushed to the master branch:

  • 567fdbf: 8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled
  • 7d6c3ad: 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode
  • 3c1023c: 8270094: Shenandoah: Provide human-readable labels for test configurations
  • 9554fba: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient
  • bf920d9: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used
  • 24e5c1a: 8272326: java/util/Random/RandomTestMoments.java had two Gaussian fails
  • 704e6b9: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked
  • e9fd4b9: 8270280: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java OCSP response error
  • efeb10b: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails
  • 551354e: 8225083: Remove Google certificate that is expiring in December 2021
  • ... and 282 more: https://git.openjdk.java.net/jdk17u/compare/9ad19f7838e6f6e128583c191c5507c1e2bd5083...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 24, 2021
@openjdk
Copy link

openjdk bot commented Aug 24, 2021

@dholmes-ora Pushed as commit bb7c412.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant