Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276177: nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption failed with "assert(def_ik->is_being_redefined()) failed: should be being redefined to get here" #321

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Dec 6, 2021

A clean backport for parity with Oracle 17.0.3.

Test:

  • nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption now passed.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276177: nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption failed with "assert(def_ik->is_being_redefined()) failed: should be being redefined to get here"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/321/head:pull/321
$ git checkout pull/321

Update a local copy of the PR:
$ git checkout pull/321
$ git pull https://git.openjdk.java.net/jdk17u pull/321/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 321

View PR using the GUI difftool:
$ git pr show -t 321

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/321.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a907b2b144f2af27392eb7c2f9656fbb1a759618 8276177: nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption failed with "assert(def_ik->is_being_redefined()) failed: should be being redefined to get here" Dec 6, 2021
@openjdk
Copy link

openjdk bot commented Dec 6, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 6, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 6, 2021

Webrevs

@zhengyu123 zhengyu123 closed this Dec 20, 2021
@zhengyu123
Copy link
Contributor Author

zhengyu123 commented Dec 20, 2021

Rebased to jdk17u-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
1 participant