Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277777: [Vector API] assert(r->is_XMMRegister()) failed: must be in x86_32.ad #323

Closed

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Dec 7, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277777: [Vector API] assert(r->is_XMMRegister()) failed: must be in x86_32.ad

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/323/head:pull/323
$ git checkout pull/323

Update a local copy of the PR:
$ git checkout pull/323
$ git pull https://git.openjdk.java.net/jdk17u pull/323/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 323

View PR using the GUI difftool:
$ git pr show -t 323

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/323.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 7, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 349328c929ccad242a344da69585404e4fea087f 8277777: [Vector API] assert(r->is_XMMRegister()) failed: must be in x86_32.ad Dec 7, 2021
@openjdk
Copy link

openjdk bot commented Dec 7, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 7, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277777: [Vector API] assert(r->is_XMMRegister()) failed: must be in x86_32.ad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 7, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 7, 2021

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Dec 23, 2021

Hi @DamonFool, please redo the PR against jdk17u-dev. I remove the jdk11u-fix-request tag in the meantime.

@DamonFool
Copy link
Member Author

Hi @DamonFool, please redo the PR against jdk17u-dev. I remove the jdk11u-fix-request tag in the meantime.

Hi @GoeLin ,
Done: openjdk/jdk17u-dev#35
Thanks.

@DamonFool
Copy link
Member Author

This had been integrated in jdk17u-dev.
So just close this one.

@DamonFool DamonFool closed this Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
2 participants