Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278309: [windows] use of uninitialized OSThread::_state #327

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Dec 15, 2021

Hi all,

I would like to backport this to jdk17. It fixes a potential error (even if it seems benign before JDK-8268773).

The commit being backported was authored by Thomas Stuefe on 8 Dec 2021 and was reviewed by David Holmes and Aleksey Shipilev.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278309: [windows] use of uninitialized OSThread::_state

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/327/head:pull/327
$ git checkout pull/327

Update a local copy of the PR:
$ git checkout pull/327
$ git pull https://git.openjdk.java.net/jdk17u pull/327/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 327

View PR using the GUI difftool:
$ git pr show -t 327

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/327.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 15, 2021

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 54993b13078ceb05736bb0e1d7ed7415c390442e 8278309: [windows] use of uninitialized OSThread::_state Dec 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2021

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278309: [windows] use of uninitialized OSThread::_state

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Dec 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 15, 2021

Webrevs

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 23, 2021

Hi tstuefe, please redo the PR against jdk17u-dev. I remove the jdk11u-fix-request tag in the meantime.

@tstuefe tstuefe closed this Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready rfr
2 participants