Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277919: OldObjectSample event causing bloat in the class constant pool in JFR recording #329

Closed

Conversation

jbachorik
Copy link

@jbachorik jbachorik commented Dec 27, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277919: OldObjectSample event causing bloat in the class constant pool in JFR recording

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/329/head:pull/329
$ git checkout pull/329

Update a local copy of the PR:
$ git checkout pull/329
$ git pull https://git.openjdk.java.net/jdk17u pull/329/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 329

View PR using the GUI difftool:
$ git pr show -t 329

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/329.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 27, 2021

👋 Welcome back jbachorik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 475ec8e6c5abc3431344d69bd46395e8c4b46e4c 8277919: OldObjectSample event causing bloat in the class constant pool in JFR recording Dec 27, 2021
@openjdk
Copy link

openjdk bot commented Dec 27, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 27, 2021

@jbachorik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277919: OldObjectSample event causing bloat in the class constant pool in JFR recording

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 27, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 27, 2021

Webrevs

@jbachorik
Copy link
Author

jbachorik commented Dec 29, 2021

Not applicable. Should be against jdk17u-dev.

@jbachorik jbachorik closed this Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
1 participant