Skip to content

8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Feb 8, 2022

Hi all,

I'd like to backport this little enhancement to cut down on testing time in jdk17u. The fix is low risk and has been in jdk18+ since last September. Fix applies cleanly.

The commit being backported was authored by Thomas Stuefe on 4 Aug 2021 and was reviewed by Thomas Schatzl and Richard Reingruber.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/332/head:pull/332
$ git checkout pull/332

Update a local copy of the PR:
$ git checkout pull/332
$ git pull https://git.openjdk.java.net/jdk17u pull/332/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 332

View PR using the GUI difftool:
$ git pr show -t 332

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/332.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2022

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 66c653c561b3b5e904579af62e23ff94952bca05 8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests Feb 8, 2022
@openjdk
Copy link

openjdk bot commented Feb 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 8, 2022

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 330 new commits pushed to the master branch:

  • 6f0f426: Merge
  • aa11a93: 8277529: SIGSEGV in C2 CompilerThread Node::rematerialize() compiling Packet::readUnsignedTrint
  • fbb7f2d: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream
  • a6c3b5d: 8277981: String Deduplication table is never cleaned up due to bad dead_factor_for_cleanup
  • e80c9fb: Merge
  • 5406f14: 8277159: Fix java/nio/file/FileStore/Basic.java test by ignoring /run/user/* mount points
  • 1e4ec1d: 8274265: Suspicious string concatenation in logTestUtils.inline.hpp
  • cd6234d: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.
  • a1049e8: 8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak
  • 565ec1a: 8275863: Use encodeASCII for ASCII-compatible DoubleByte encodings
  • ... and 320 more: https://git.openjdk.java.net/jdk17u/compare/912ae51344e7694be3a9c1f3d60306ffcdd2fe38...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 8, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 8, 2022

Webrevs

@tstuefe tstuefe closed this Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant