Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282761: XPathFactoryImpl remove setProperty and getProperty methods #337

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 16, 2022

I backport this for parity with 17.0.3-oracle.
It's a clean backout of 8276141


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282761: XPathFactoryImpl remove setProperty and getProperty methods ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/337/head:pull/337
$ git checkout pull/337

Update a local copy of the PR:
$ git checkout pull/337
$ git pull https://git.openjdk.java.net/jdk17u pull/337/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 337

View PR using the GUI difftool:
$ git pr show -t 337

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/337.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 16, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 16, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 16, 2022

Webrevs

@yan-too
Copy link

yan-too commented Mar 16, 2022

It would go to 17.0.4, right, in July? There may be a merge necessary then because of some XPATHErrorResources.java context in a backport series I've posted on Mar 10. Maybe it would be easier to do it after a build 01? At least I have such a plan for 15/13 as there seems to be no rush.

@openjdk
Copy link

openjdk bot commented Mar 17, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282761: XPathFactoryImpl remove setProperty and getProperty methods

Reviewed-by: clanger, yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 17, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Mar 17, 2022

Thanks for the quick reviews!
/integrate

@openjdk
Copy link

openjdk bot commented Mar 17, 2022

Going to push as commit c3ea7ca.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 17, 2022
@openjdk openjdk bot closed this Mar 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 17, 2022
@openjdk
Copy link

openjdk bot commented Mar 17, 2022

@GoeLin Pushed as commit c3ea7ca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8282761 branch March 17, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants