-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8282761: XPathFactoryImpl remove setProperty and getProperty methods #337
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
It would go to 17.0.4, right, in July? There may be a merge necessary then because of some XPATHErrorResources.java context in a backport series I've posted on Mar 10. Maybe it would be easier to do it after a build 01? At least I have such a plan for 15/13 as there seems to be no rush. |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks for the quick reviews! |
Going to push as commit c3ea7ca. |
I backport this for parity with 17.0.3-oracle.
It's a clean backout of 8276141
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/337/head:pull/337
$ git checkout pull/337
Update a local copy of the PR:
$ git checkout pull/337
$ git pull https://git.openjdk.java.net/jdk17u pull/337/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 337
View PR using the GUI difftool:
$ git pr show -t 337
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/337.diff