Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286601: Mac Aarch: Excessive warnings to be ignored for build jdk #339

Closed

Conversation

adamfarley
Copy link

@adamfarley adamfarley commented May 13, 2022

Hi all,

This pull request contains a backport of commit 40f43c6b from the openjdk/jdk repository.

The commit being backported was authored by Adam Farley on 12 May 2022 and was reviewed by Erik Joelsson.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286601: Mac Aarch: Excessive warnings to be ignored for build jdk

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/339/head:pull/339
$ git checkout pull/339

Update a local copy of the PR:
$ git checkout pull/339
$ git pull https://git.openjdk.java.net/jdk17u pull/339/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 339

View PR using the GUI difftool:
$ git pr show -t 339

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/339.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2022

👋 Welcome back afarley! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 40f43c6b1ffc88d55dd3223f5d0259ae73cf0356 8286601: Mac Aarch: Excessive warnings to be ignored for build jdk May 13, 2022
@openjdk
Copy link

openjdk bot commented May 13, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 13, 2022

@adamfarley This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286601: Mac Aarch: Excessive warnings to be ignored for build jdk

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 2680e83: 8285728: Alpine Linux build fails with busybox tar
  • cc91c6e: 8284758: [linux] improve print_container_info
  • 7c87493: 8284754: print more interesting env variables in hs_err and VM.info
  • 5c1835d: 8283323: libharfbuzz optimization level results in extreme build times
  • 7cef5a5: 8286198: [linux] Fix process-memory information
  • f9a6e0c: 8285956: (fs) Excessive default poll interval in PollingWatchService
  • bbd500f: 8280593: [PPC64, S390] redundant allocation of MacroAssembler in StubGenerator ctor
  • 230cd5e: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend
  • 296dc78: 8268773: Improvements related to: Failed to start thread - pthread_create failed (EAGAIN)
  • b6404c8: 8282008: Incorrect handling of quoted arguments in ProcessBuilder
  • ... and 2 more: https://git.openjdk.java.net/jdk17u/compare/1b1500a0511c1ae95c5221709dd1ed2dc5bc6bd7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 13, 2022
@mlbridge
Copy link

mlbridge bot commented May 13, 2022

Webrevs

@adamfarley
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 17, 2022
@openjdk
Copy link

openjdk bot commented May 17, 2022

@adamfarley
Your change (at version dfb9d40) is now ready to be sponsored by a Committer.

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine and I see jdk18u-fix-yes on the bug.

@gnu-andrew
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 23, 2022

Going to push as commit 461fb32.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 2680e83: 8285728: Alpine Linux build fails with busybox tar
  • cc91c6e: 8284758: [linux] improve print_container_info
  • 7c87493: 8284754: print more interesting env variables in hs_err and VM.info
  • 5c1835d: 8283323: libharfbuzz optimization level results in extreme build times
  • 7cef5a5: 8286198: [linux] Fix process-memory information
  • f9a6e0c: 8285956: (fs) Excessive default poll interval in PollingWatchService
  • bbd500f: 8280593: [PPC64, S390] redundant allocation of MacroAssembler in StubGenerator ctor
  • 230cd5e: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend
  • 296dc78: 8268773: Improvements related to: Failed to start thread - pthread_create failed (EAGAIN)
  • b6404c8: 8282008: Incorrect handling of quoted arguments in ProcessBuilder
  • ... and 2 more: https://git.openjdk.java.net/jdk17u/compare/1b1500a0511c1ae95c5221709dd1ed2dc5bc6bd7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 23, 2022
@openjdk openjdk bot closed this May 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 23, 2022
@openjdk
Copy link

openjdk bot commented May 23, 2022

@gnu-andrew @adamfarley Pushed as commit 461fb32.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger
Copy link
Contributor

This should have been done in the jdk17u-dev repository (for the next backport).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants