Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled #34

Closed
wants to merge 1 commit into from

Conversation

thejasviv
Copy link
Member

@thejasviv thejasviv commented Aug 23, 2021

This is a clean, straight backport of the following bug:

8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled

Patch applies clean, and test passes post patch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/34/head:pull/34
$ git checkout pull/34

Update a local copy of the PR:
$ git checkout pull/34
$ git pull https://git.openjdk.java.net/jdk17u pull/34/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 34

View PR using the GUI difftool:
$ git pr show -t 34

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/34.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 23, 2021

👋 Welcome back tvoniadka! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4bd37c315333325b69db8d55c0c3aaf74c95024f 8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled Aug 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

@thejasviv This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 7d6c3ad: 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode
  • 3c1023c: 8270094: Shenandoah: Provide human-readable labels for test configurations
  • 9554fba: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient
  • bf920d9: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used
  • 24e5c1a: 8272326: java/util/Random/RandomTestMoments.java had two Gaussian fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Aug 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 23, 2021

Webrevs

@thejasviv
Copy link
Member Author

@thejasviv thejasviv commented Aug 23, 2021

/integrate

@openjdk openjdk bot added the sponsor label Aug 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

@thejasviv
Your change (at version be0e170) is now ready to be sponsored by a Committer.

@akolarkunnu
Copy link
Contributor

@akolarkunnu akolarkunnu commented Aug 23, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

Going to push as commit 567fdbf.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 7d6c3ad: 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode
  • 3c1023c: 8270094: Shenandoah: Provide human-readable labels for test configurations
  • 9554fba: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient
  • bf920d9: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used
  • 24e5c1a: 8272326: java/util/Random/RandomTestMoments.java had two Gaussian fails

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Aug 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 23, 2021

@akolarkunnu @thejasviv Pushed as commit 567fdbf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants