Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282947: JFR: Dump on shutdown live-locks in some conditions #348

Closed

Conversation

judovana
Copy link
Contributor

@judovana judovana commented Jul 14, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282947: JFR: Dump on shutdown live-locks in some conditions

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u pull/348/head:pull/348
$ git checkout pull/348

Update a local copy of the PR:
$ git checkout pull/348
$ git pull https://git.openjdk.org/jdk17u pull/348/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 348

View PR using the GUI difftool:
$ git pr show -t 348

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/348.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 14, 2022

👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569 8282947: JFR: Dump on shutdown live-locks in some conditions Jul 14, 2022
@openjdk
Copy link

openjdk bot commented Jul 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 14, 2022

@judovana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282947: JFR: Dump on shutdown live-locks in some conditions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 14, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 14, 2022

Webrevs

@RealCLanger
Copy link
Contributor

Hi @judovana,
I think this is a sensible backport, but please do it at the jdk17u-dev repository, which would be the correct location. Thanks!

@judovana judovana closed this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
2 participants