8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large

[jerboaa]

PR to backout the change of JDK-8279219. I'll change this to the proper backport title once JDK 19 backout is done.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large

Reviewers

• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u pull/350/head:pull/350
$ git checkout pull/350

Update a local copy of the PR:
$ git checkout pull/350
$ git pull https://git.openjdk.org/jdk17u pull/350/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 350

View PR using the GUI difftool:
$ git pr show -t 350

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/350.diff

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into jdk17.0.4.1 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (97f2fd07)

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[RealCLanger]

Looks good. JDK-8284369 is backouted by this as well but that was a specific fix for/after JDK-8279219 anyway.

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk17.0.4.1 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk17.0.4.1 branch, type /integrate in a new comment.

[jerboaa]

/integrate

[openjdk]

Going to push as commit 02fa4be.

[openjdk]

@jerboaa Pushed as commit 02fa4be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[jerboaa]

@erikj79 @kevinrushforth Would either of you know why we didn't get a 17.0.4.1 backport bug for this? Similar issue to openjdk/jdk11u#49 (comment) ?

[erikj79]

(I don't currently have any github notifications turned on so tagging me doesn't help)
The reason this commit hasn't been notified to JBS is that Skara is currently choking on a tag that was updated/changed in this repo. A fix for that is currently on review in SKARA-1355. I will manually go and get this unstuck for now.

[RealCLanger]

Thanks. I already thought, force-pushing the tag would cause trouble somehwere. But it seems like in this case it helps to get the tooling more robust 😄
One other thing I noted: The backport for 17.0.4.1 now mentions "Resolved in build: master". However, the b01 tag was already set, so it should be b01. Is that an expected outcome due to working on another branch in the repo? Or because 17.0.5 tags are already in place as well?

[jerboaa]

One other thing I noted: The backport for 17.0.4.1 now mentions "Resolved in build: master". However, the b01 tag was already set, so it should be b01.

Fixed this manually. Still interested to hear why that didn't work.