Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8028265: Add legacy tz tests to OpenJDK #353

Closed
wants to merge 1 commit into from

Conversation

alvdavi
Copy link
Contributor

@alvdavi alvdavi commented Sep 14, 2022

Clean backport of JDK-8028265, bringing timezone tests before updating timezone data to 2022c


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u pull/353/head:pull/353
$ git checkout pull/353

Update a local copy of the PR:
$ git checkout pull/353
$ git pull https://git.openjdk.org/jdk17u pull/353/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 353

View PR using the GUI difftool:
$ git pr show -t 353

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/353.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2022

👋 Welcome back alvdavi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 92deab546549ca549408a983fe361d9536d2cd37 8028265: Add legacy tz tests to OpenJDK Sep 14, 2022
@openjdk
Copy link

openjdk bot commented Sep 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 14, 2022

@alvdavi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8028265: Add legacy tz tests to OpenJDK

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 14, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2022

Webrevs

@gnu-andrew
Copy link
Member

Do the tests all pass?

If so, this can go straight to a jdk17u-fix-request label on the bug.

@alvdavi
Copy link
Contributor Author

alvdavi commented Sep 15, 2022

Yes, all test pass. Label added

@jerboaa
Copy link
Contributor

jerboaa commented Sep 15, 2022

Yes, all test pass. Label added

Since this is for jdk17u (October), not jdk17u-dev (January), the label ought to be jdk17u-critical-request. Please also add a rational to the bug via a "Fix Request" comment next time. Added it for you this time ;-)

@GoeLin
Copy link
Member

GoeLin commented Sep 15, 2022

Approved. You can push.

@alvdavi
Copy link
Contributor Author

alvdavi commented Sep 15, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 15, 2022
@openjdk
Copy link

openjdk bot commented Sep 15, 2022

@alvdavi
Your change (at version 00ce9ac) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

Got the approval.

@openjdk
Copy link

openjdk bot commented Sep 15, 2022

Going to push as commit 6f2bbc4.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 15, 2022
@openjdk openjdk bot closed this Sep 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 15, 2022
@openjdk
Copy link

openjdk bot commented Sep 15, 2022

@phohensee @alvdavi Pushed as commit 6f2bbc4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gnu-andrew
Copy link
Member

Yes, all test pass. Label added

Since this is for jdk17u (October), not jdk17u-dev (January), the label ought to be jdk17u-critical-request. Please also add a rational to the bug via a "Fix Request" comment next time. Added it for you this time ;-)

My bad. I realised this morning I'd mentioned the wrong one. Glad to see it's sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
5 participants