-
Notifications
You must be signed in to change notification settings - Fork 195
8028265: Add legacy tz tests to OpenJDK #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back alvdavi! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@alvdavi This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
Do the tests all pass? If so, this can go straight to a |
|
Yes, all test pass. Label added |
Since this is for |
|
Approved. You can push. |
|
/integrate |
|
/sponsor Got the approval. |
|
Going to push as commit 6f2bbc4. |
|
@phohensee @alvdavi Pushed as commit 6f2bbc4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
My bad. I realised this morning I'd mentioned the wrong one. Glad to see it's sorted. |
Clean backport of JDK-8028265, bringing timezone tests before updating timezone data to 2022c
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u pull/353/head:pull/353$ git checkout pull/353Update a local copy of the PR:
$ git checkout pull/353$ git pull https://git.openjdk.org/jdk17u pull/353/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 353View PR using the GUI difftool:
$ git pr show -t 353Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/353.diff