-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled #354
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for backporting!
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Pre-submit failure Both unrelated. |
/integrate |
I backport this for parity with 17.0.5-oracle.
I had to resolve the change in a few places:
src/java.base/share/classes/sun/security/provider/certpath/AlgorithmChecker.java
Where "true" is added to permits() call, code looks different. This is because
"8243585: AlgorithmChecker::check throws confusing exception when it rejects the signer key"
is not backported.
Added true to all calls of permits().
src/java.base/share/classes/sun/security/util/DisabledAlgorithmConstraints.java
Method permits() has a slightly different implementation in 17.
The new parameter is just switching off the check. I
wrapped the check around the code in 17 as in the original.
src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java
Copyright
Call to permits() has different argument.
It already ran successful through our nightly testing.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u pull/354/head:pull/354
$ git checkout pull/354
Update a local copy of the PR:
$ git checkout pull/354
$ git pull https://git.openjdk.org/jdk17u pull/354/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 354
View PR using the GUI difftool:
$ git pr show -t 354
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/354.diff