Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 #36

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Aug 24, 2021

Backport of [macos] Build failure with Xcode 13.0 after JDK-8264848


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/36/head:pull/36
$ git checkout pull/36

Update a local copy of the PR:
$ git checkout pull/36
$ git pull https://git.openjdk.java.net/jdk17u pull/36/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 36

View PR using the GUI difftool:
$ git pr show -t 36

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/36.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 24, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@DamonFool DamonFool changed the title Backport of JDK-8272700 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 Aug 24, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 24, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 24, 2021

Webrevs

@DamonFool
Copy link
Member Author

/label backport

@openjdk
Copy link

openjdk bot commented Aug 24, 2021

@DamonFool The label backport is not a valid label. These labels are valid:

@DamonFool DamonFool changed the title 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 Backport d007be0952abdc8beb7b68ebf7529a939162307b Aug 24, 2021
@openjdk openjdk bot changed the title Backport d007be0952abdc8beb7b68ebf7529a939162307b 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848 Aug 24, 2021
@openjdk
Copy link

openjdk bot commented Aug 24, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 24, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 24, 2021
@DamonFool
Copy link
Member Author

Backport has been approved.
So integrate it.
/integrate

@openjdk
Copy link

openjdk bot commented Aug 24, 2021

Going to push as commit 648f3f6.

@openjdk openjdk bot closed this Aug 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 24, 2021
@openjdk
Copy link

openjdk bot commented Aug 24, 2021

@DamonFool Pushed as commit 648f3f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant