Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR #363

Closed
wants to merge 1 commit into from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Dec 22, 2022

Clean backport (modulo copyright header in DisabledAlgorithmConstraints) fixing a regression introduced with JDK-8269039: Disable SHA-1 Signed JARs which was included in 17.0.5. This should be low-risk as it mainly removes use of java.util.Calendar API usage in DisabledAlgorithmConstraints which can cause issues with applications that contain CalendarDataProviders in signed jars. See JDK-8297684 for details.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u pull/363/head:pull/363
$ git checkout pull/363

Update a local copy of the PR:
$ git checkout pull/363
$ git pull https://git.openjdk.org/jdk17u pull/363/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 363

View PR using the GUI difftool:
$ git pr show -t 363

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/363.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2022

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR Dec 22, 2022
@openjdk
Copy link

openjdk bot commented Dec 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 22, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 22, 2022

Webrevs

@jerboaa
Copy link
Contributor Author

jerboaa commented Dec 22, 2022

@RealCLanger Could you please review this? Thank you!

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Dec 22, 2022

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@jerboaa
Copy link
Contributor Author

jerboaa commented Dec 23, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 23, 2022

Going to push as commit 0ab310e.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 23, 2022
@openjdk openjdk bot closed this Dec 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 23, 2022
@openjdk
Copy link

openjdk bot commented Dec 23, 2022

@jerboaa Pushed as commit 0ab310e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants