8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates #371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This pull request contains a backport of JDK-8303465, commit ac41c030 from the openjdk/jdk repository.
This is an improvement for the handling of certificates from the MacOSX keychain which regressed since the April 2022 CPU update (17.0.3) and does not show all appropriate certificates that it should do. The fix was just recently submitted in head and came too late for the regular dev cycle for 17.0.8. However, I would ask to include it now in rampdown, since we have an open customer issue that it would solve. Since our customer is consuming the JDK via Eclipse/Adoptium, it would also not suffice to cherry-pick it into the SapMachine build only, so that's why my request is to take it into 17.0.8.
The backport applied cleanly. It involves a CSR but the original CSR has been approved for all relevant backport releases.
Thanks
Christoph
Progress
Issues
"3"
)Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u.git pull/371/head:pull/371
$ git checkout pull/371
Update a local copy of the PR:
$ git checkout pull/371
$ git pull https://git.openjdk.org/jdk17u.git pull/371/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 371
View PR using the GUI difftool:
$ git pr show -t 371
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/371.diff
Webrev
Link to Webrev Comment