Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg #381

Closed
wants to merge 1 commit into from

Conversation

robehn
Copy link
Contributor

@robehn robehn commented Oct 4, 2023

Hi all,

This pull request contains a backport of commit 2d154fcd from the openjdk/jdk repository.

The commit being backported was authored by Robbin Ehn on 28 Sep 2023 and was reviewed by Ludovic Henry and Fei Yang.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u.git pull/381/head:pull/381
$ git checkout pull/381

Update a local copy of the PR:
$ git checkout pull/381
$ git pull https://git.openjdk.org/jdk17u.git pull/381/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 381

View PR using the GUI difftool:
$ git pr show -t 381

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/381.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2023

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2d154fcd0de0612f58abbc5027f409b9b2eb0dc2 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg Oct 4, 2023
@openjdk
Copy link

openjdk bot commented Oct 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 4, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 4, 2023

Webrevs

@robehn
Copy link
Contributor Author

robehn commented Oct 6, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 6, 2023

Going to push as commit 8afd87b.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 6, 2023
@openjdk openjdk bot closed this Oct 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 6, 2023
@openjdk
Copy link

openjdk bot commented Oct 6, 2023

@robehn Pushed as commit 8afd87b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gnu-andrew
Copy link
Member

Why has this been pushed to 17u? This tree is frozen for the release of 17.0.9.

@mlbridge
Copy link

mlbridge bot commented Oct 8, 2023

Mailing list message from Lindenmaier, Goetz on jdk-updates-dev:

Hi,

I crafted a backout: JDK-8317700.
I please need review&approval.

Best, Goetz.

@robehn
Copy link
Contributor Author

robehn commented Oct 9, 2023

Why has this been pushed to 17u? This tree is frozen for the release of 17.0.9.

Yes, sorry, wrong repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants